Problem/Motivation

Each project in drupal-org.make is configured with a 'subdir': 'contrib'. However, a make file can have a default subdir so there is no need to configure this on a per-project basis.

Proposed resolution

Add a default subdir 'contrib' for projects. Remove the declaration per project.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#3 dvg-add_subdir_default-3032722-3.patch15.95 KBpaulvandenburg
#2 dvg-add_subdir_default-3032722-2.patch16.03 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new dvg-add_subdir_default-3032722-2.patch16.03 KB

Attached patch adds a default subdir 'contrib' for projects and removes the declaration per project.

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dvg-add_subdir_default-3032722-3.patch15.95 KB

Looks good and indeed much better than defining the subdir repeatedly for each module.

I've rerolled the patch as it no longer applied to dev.

  • paulvandenburg committed 53651a2 on 7.x-1.x 
    Issue #3032722 by idebr, paulvandenburg: drupal-org.make: replace subdir...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.