Problem/Motivation

Replace all the occurrence of deprecated assertText() method

Proposed resolution

$this->assertSession()->responseContains() for non-HTML responses. Unlike the deprecated assertText()

$this->assertSession()->responseContains()

CommentFileSizeAuthor
#13 3032673-13.patch7.04 KBhmendes
#12 interdiff.txt10.47 KBLal_
#11 3032673-11.patch6.65 KBLal_
#9 3032673-8.patch8.67 KBshubham.prakash
#7 interdiff.txt6.91 KBLal_
#7 3032673-7.patch7.73 KBLal_
#5 interdiff.txt1 KBmile23
#5 3032673_5.patch0 bytesmile23
#4 patch-apply.PNG4.95 KBmaliknaik
#2 removed_deprecated_assertText-3032673-2.patch964 bytesakshay_d

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Location Bangalore
commented
Status: Active » Needs review
StatusFileSize
new removed_deprecated_assertText-3032673-2.patch964 bytes

Replaced deprecated assertText() method

akshay_d’s picture

akshay_d
Location Bangalore
commented

Please Review the patch.

maliknaik’s picture

maliknaik commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new patch-apply.PNG4.95 KB

Patch #2 applies cleanly.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3032673_5.patch0 bytes
new interdiff.txt1 KB

AssertLegacyTrait::assertText() is deprecated for removal in Drupal 10, but it's a worthwhile change.

CS changes, re-patched so the testbot can go.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Component: Batch Example » Other
Status: Needs review » Needs work

There are still a lot of usages of assertText() in BTB tests in Examples. Let's grab them all.

Lal_’s picture

Lal_
He\Him
commented
Status: Needs work » Needs review
StatusFileSize
new 3032673-7.patch7.73 KB
new interdiff.txt6.91 KB

I hope this is it..

Status: Needs review » Needs work

The last submitted patch, 7: 3032673-7.patch, failed testing. View results

shubham.prakash’s picture

shubham.prakash commented
Status: Needs work » Needs review
StatusFileSize
new 3032673-8.patch8.67 KB
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Version: 8.x-1.x-dev » 3.x-dev

The default branch is 3.x-dev now, which is Drupal 9 compatible

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 3032673-11.patch6.65 KB

re-rolling according to the branch 3.x

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new interdiff.txt10.47 KB

Adding interdiff

hmendes’s picture

hmendes commented
StatusFileSize
new 3032673-13.patch7.04 KB

Re-rolling patch.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

Checked with grep -nR "assertText" ., no more assertText() in the 3.x branch.

Instead of marking this Closed (outdated), changing it to Fixed for giving credit!

Thanks!

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.