Closed (fixed)
Project:
Claro
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Feb 2019 at 13:10 UTC
Updated:
13 Sep 2019 at 17:19 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
andrewmacpherson commentedThanks for filing this. There are some related core issues about improving the tabledrag behaviour. I don't think these are things to be solved in Claro, but it would be good if Claro assumes that they will
In particular, if the drag-handle button icon is redesigned, it will be good to include icon variants for the nested tree and up/down versions.
Comment #3
andrewmacpherson commentedComment #4
ckrinaComment #5
brightboldComment #6
brightboldComment #7
bnjmnmI had been working on #3023326: Field Cardinality Style Update and did not realize this issue existed as I was filtering my search by the 'code' component. Fortunately, most of the work I'd done on that issue is more pertinent to this one anyway. The attached patch pushes things forward and should be compatible with the pending designs. As noted in the screenshot filename, the menu UI is not yet ideal on mobile.
There is also JS that I strongly suspect will change - it copies tabledrag labels to their own table cell so the tabledrag handle and label can have consistent alignment. I'm pretty sure there's a nicer approach, but perhaps the approach in the fix will help expedite the better solution.
There's a little bit of styling that is specific to #3023326: Field Cardinality Style Update - it may be easiest to just update the IS to include those changes, but I'll let someone else be the final judge of that.
Comment #8
ckrinaLet's use the same from Seven for now.
Let's use the same from Seven for now.
Yes, the one pointed is correct.
Comment #9
huzookaComment #10
huzookaHere we have the first patch.
Details:
dragRow()is wrong. Actually this happens by using the original JS with Seven as well.Comment #11
huzookaFound an issue with Safari (handle is unfocusable).
Comment #12
huzookaComment #13
huzookaComment #14
huzookaThe attached patch fixes #10.3 and #11.
Comment #15
lauriiiComment #16
lauriiiDuplicate height property
It seems like 0.0625rem would work better for this since this is 1px too much.
Good catch. 👍
We should link this to #3077938: Add a new Drupal.theme JavaScript function for tabledrag handle to allow themes customize the handle's markup.
Maybe the focus could look more like this?
Comment #17
finnsky commentedComment #18
finnsky commentedComment #19
katriencPatch with changes in #14
#16:
1. removed the duplicated height
2.
I also agree that 0.0625rem works better, I've added it to the patch
4. the borders around the handler should be a square (not a rectangle).
I changed the left and right in .tabledrag-handle:focus::before (tabledrag.css).
Comment #21
lauriiiThis looks great! Thank you @lot007! 👏