Problem/Motivation

I think it would be better to use the one service to manage OneSignal configurations instead \Drupal::config('onesignal.config')->get('...');

Proposed resolution

Implement custom OneSignal config manager service.

Remaining tasks

  1. Create patch
  2. Review/RTBC
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 onesignal-implemented_config_manager-3032142-2.patch19.75 KBi-trokhanenko

Comments

i-trokhanenko created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new onesignal-implemented_config_manager-3032142-2.patch19.75 KB

Please review!

Roman Dyn’s picture

Roman Dyn commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Hi. I reviewed patch #2, tested configuration form and hook_page_attachments(). All work well for me. Thanks.

  • jcmartinez committed 20e8230 on 8.x-1.x 
    Issue #3032142 by i-trokhanenko: Implement OneSignal config manager...
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented

@jcmartinez, thanks for the committed patch. I think the issue can be closed.

jcmartinez’s picture

jcmartinez
Location Raleigh, NC, USA
commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#3031352: Do not add OneSignal JS code when missing API key

Fixed by patch from https://www.drupal.org/project/onesignal/issues/3031352

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.