Replace deprecated REQUEST_TIME

Replace deprecated REQUEST_TIME

Time Service Added and REQUEST_TIME deprecated

Hi Thalles,
Any issue in this patch

Closed #3034226: Replace deprecated REQUEST_TIME on scheduler_api_test/scheduler_api_test.module as a duplicate issue.

The patch needs a re-roll. Also I think we should consider creating a property requestTime on SchedulerBrowserTestBase because the change affects 12 different test classes, all of which extend SchedulerBrowserTestBase. Does it make sense to do this once and use $this->requestTime in the tests, rather than call \Drupal::time()->getRequestTime() in each of the 12 test files?

1. Rerolled #3 against 8.x-1.x
2. Implemented dependency injection on \Drupal\scheduler\SchedulerManager
3. Added the time service to \Drupal\Tests\scheduler\Functional\SchedulerBrowserTestBase

Reroll after #3031199: Replace assertRaw(t()) with assertText() was committed.

Thanks. However, the following two issues are more urgent as they are currently causing test failures in Travis.
#3034805: Using setPublished() with a $published parameter is deprecated in 8.3
#3034986: Replace deprecated SafeMarkup::checkPlain()

Both of these should be done first, so that we get clean test runs. Other patches may need a re-roll, so let's concentrate on these two before any others.

Linked to parent issue.

Un-postponing now that the following are in:
#3034805: Using setPublished() with a $published parameter is deprecated in 8.3
#3034986: Replace deprecated SafeMarkup::checkPlain()

Rerolled against 8.x-1.x

Needed a re-roll after recent commits.

#19 was a random unrelated failure regarding mkdir()

I have simplified the testing code, rather than storing the time service and calling $this->time->getRequestTime() every time, we now store the request time numeric value as a property of SchedulerBrowserTestBase via $this->requestTime = $this->container->get('datetime.time')->getRequestTime(). Then each test can simply use $this->requestTime in every place that we had $REQUEST_TIME

@idebr I'd be interested to hear your opinion on this. The tests work, and it would appear to be more efficient than calling the method many times. I have not changed your code in SchedulerManager, only the tests.

The other (minor) change is in .module where the value is now stored and reused instead of calling the method three times.

Re-rolled patch #21 due to the commit in #2867271: assertEqual() is deprecated in Drupal 9. Replace with assertEquals()

Thanks idebr, Satyanarayan Reddy, thalles. Commited.