Background Image Field (bg_img_field)

Background Image FIeld module allows you to create a field on an entity type. It requires responsive images mapping in order to offer the best image quality for the device it is rendering on. The field will define the CSS selector to attach the background image too and then allow you basic CSS options repeat, size, and position so you can have dynamic control per image in your content. The CSS is added to the head of the page in an inline style tag.

Project link

https://www.drupal.org/project/bg_img_field

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/bg_img_field.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-bg_img_field.g...

Manual reviews of other projects

https://www.drupal.org/project/projectapplications/issues/3032111#commen...
https://www.drupal.org/project/projectapplications/issues/3026709#commen...
https://www.drupal.org/project/projectapplications/issues/3031988#commen...

Comments

TheLostCookie created an issue. See original summary.

jfortune’s picture

jfortune commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
saesa’s picture

saesa commented

I advise you to put an image on the module page to have a better perspective, it is something that users appreciate :)

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Status: Needs review » Needs work

Hi, thanks for the contribution, I've made some brief check using the review template, here are the results:

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
No: Does not follow the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage:
Nothing really bad has been found, the only one advise is to use $this->t()(from StringTranslationTrait) instead of t() in your plugins

So, the only important one is Licensing, so please check it out - https://www.drupal.org/about/licensing#project-licensing.

Regards, Valentine

jfortune’s picture

jfortune commented

Thank you @saesa, I have uploaded images to the project page. comment #4

Thank you @Valentine94

comment #5 fixes

I have updated the License.txt.

All non-static functions that are using the t() function are now using $this->t() instead.

jfortune’s picture

jfortune commented
Status: Needs work » Needs review
jfortune’s picture

jfortune commented
Issue summary: View changes
Issue tags: +PAreview: review bonus
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: [D8]Background Image field » [D8] Background Image field
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.