See #3026264: UserAccessControlHandler::checkFieldAccess() denies access to mail field without varying by the ‘user’ cache context.

This broke our tests on 8.7 and is blocking automated patch testing.

CommentFileSizeAuthor
#10 3031750-10.patch8.7 KBwim leers
#10 interdiff.txt1.19 KBwim leers
#8 3031750-8.patch7.83 KBwim leers
#8 interdiff.txt1.44 KBwim leers
#7 3031750-7.patch6.71 KBwim leers
#7 interdiff.txt528 byteswim leers
#5 3031750-5.patch6.77 KBgabesullice
#5 interdiff.txt932 bytesgabesullice
#4 3031750-4.patch6.52 KBgabesullice
#4 interdiff.txt698 bytesgabesullice
#2 3031750-2.patch6.71 KBwim leers

Comments

gabesullice created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3031750-2.patch6.71 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3031750-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt698 bytes
new 3031750-4.patch6.52 KB

Let's fix the CS violations.

It looks like they're masking some failures on 8.7.

gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new interdiff.txt932 bytes
new 3031750-5.patch6.77 KB

I think it was just a typo.

Status: Needs review » Needs work

The last submitted patch, 5: 3031750-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt528 bytes
new 3031750-7.patch6.71 KB 
+++ b/tests/src/Functional/UserTest.php
@@ -155,7 +155,7 @@ class UserTest extends ResourceTestBase {
+      if (floatval(\Drupal::VERSION) >= 8.7) {

LOL

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff.txt1.44 KB
new 3031750-8.patch7.83 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task
Priority: Major » Critical

This is not a bug in the JSON:API module, this is core fixing stuff, and JSON:API needing to follow suit. Changing issue metadata.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff.txt1.19 KB
new 3031750-10.patch8.7 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Green on 8.5+8.6+8.7. Let's unbreak HEAD!

  • Wim Leers committed 73ae304 on 8.x-2.x 
    Issue #3031750 by Wim Leers, gabesullice: Drupal core compatibility:...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.