Closed (fixed)
Project:
Pathauto
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Feb 2019 at 16:22 UTC
Updated:
31 Mar 2019 at 13:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
thallesFollow the patch!
Comment #3
idebr commentedLet's add an empty post_update hook so the services container is rebuilt, see
\taxonomy_post_update_clear_entity_bundle_field_definitions_cache()for an example. Existing sites will trigger an error:ArgumentCountError: Too few arguments to function Drupal\pathauto\PathautoGenerator::__construct()Let's use $alias_type_manager for consistency with the other variables.
Comment #4
berdir1. I'm not that fond of the empty post update pattern, we could for BC just make the arguments optional and fall back to \Drupal::service() in the constructor, then it will work fine too.
Comment #5
thallesFollow the new patch!
Comment #7
berdirThanks, committed.