In settings of entity reference field, the entity type is marked as required, but the validation allows this to be empty.
A desired feature, as contained in Drupal 7, is when this option are left empty, all bundles are allowed to be referenced.
admin/structure/types/manage/article/fields) to the Article content typeMake the entity type requirement as FALSE and add a short description to notice the users about de behavior when this setting is leave as empty.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 3031637-13.patch | 2.42 KB | murilohp |
| #13 | interdiff_7-13.txt | 1.3 KB | murilohp |
| #13 | 3031637-13-test-only.patch | 1.49 KB | murilohp |
| #7 | drupal-entity_reference_target_bundles-3031637-7.patch | 945 bytes | swentel |
| #2 | drupal-entity_reference_target_bundles-3031637-1.patch | 964 bytes | lucass |
Comments
Comment #2
lucass commentedComment #3
damiengr commentedComment #4
hchonovWe need a test coverage for this. But I agree that we need this feature.
Comment #7
swentel commentedRerolled for 9.3.x, also using $this->t(
DefaultSelection::validateConfigurationForm already has a comment which explains why the storage either contains array or NULL. So the API itself allows it already (and tested it manually). Couldn't find a test immediately that actively tests this feature.
Comment #12
smustgrave commentedThis issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.
Seems like a great feature.
#7 still applies to 10.1 too!
Was previously tagged for tests which still need to happen
Thanks!
Comment #13
murilohp commentedI was taking a look at the bug and I've written a new test for it, the test will try to save a new reference field without checking any bundles and then validate the new description. I think this will cover the feature.
PS: I've also updated the IS with some steps to reproduce.
Comment #14
smustgrave commentedLets see to review and see what happens!
Comment #15
smustgrave commentedGreat job on the tests!
Comment #16
amateescu commentedThe target bundles selector was made required based on UX review of the Entity Reference, very soon after it went into 8.x core, see #1953444: Make 'target bundles' required on the Entity reference instance settings form and #1847596-119: Remove Taxonomy term reference field in favor of Entity reference.
We shouldn't undo that change without going through a discussion with the usability team.
Comment #17
simohell commentedWhat happens if we have content types
- Dog
- Horse
- Kennel
- Stable
In Kennel we have field referencing Dog and in Stable we reference Horses.
Content type Dog is deleted.
Will Kennel start referencing Horses as no content type is selected?
We add content type Fence material.
Will Kennel then reference Horses and Fence materials?
Comment #18
benjifisherUsability review
We discussed this issue at #3340893: Drupal Usability Meeting 2023-02-17. That issue has a link to a recording of the meeting.
For the record, the attendees at the usability meeting were @AaronMcHale, @BlackBamboo, @benjifisher, @gaurav mahlawat, @lauriii, @rkoller, @shaal, and @simohell.
The points raised in #16 and #17 are valid. We agreed not to follow this approach.
An alternative to consider is adding an explicit option to toggle between "allow only the selected types" and "allow any but the selected types". This would be similar to the way page restrictions work when configuring block visibility. The other block visibility options do not follow this pattern, but perhaps they should. (See #2986958: Add support for negating user role condition for block visibility, for example. I am adding that as a related issue.)
Another alternative would be to add an "All" option at the top of the list. If that is selected, then hide the other options.
Before implementing either alternative, it would help a lot to do some user testing and consider other places in Drupal core that folllow similar patterns.
Comment #20
jonathanshaw