Deprecated entity_get_display() and entity_get_form_display()

There is a failure in the code but here's one hint:

+++ b/modules/ctools_entity_mask/tests/src/Kernel/EntityMaskTest.php
@@ -86,7 +87,7 @@ class EntityMaskTest extends KernelTestBase {
-    $display = entity_get_form_display('fake_block_content', 'basic', 'default');
+    $display = \Drupal::service('entity_display.repository')->getViewDisplay('fake_block_content', 'basic', 'default');

This is getting the form display not the view display?

Thanks for trying to fix these!

I have changed the getViewDisplay to getFormDisplay as the function entity_get_form_display is form-display function, not a view display one. Please review and let me know whether my step was correct or not. Would like to work on this issue if anything more required thank you.

Thank you again, the failed tests will need to be resolved before I can commit this

Sorry for the mistake. I forgot to include the EntityTypeManagerManager

Added the entityformdisplayinterface.

I am not able to get why am I getting errors when I have include
use Drupal\Core\Entity\Display\EntityFormDisplayInterface;
use Drupal\Core\Entity\EntityTypeManagerManager;

It is throwin an error that an undefined function is being called. But the functions getFormDisplay and getViewDisplay are valid right. Can some one please tell me where am i going wrong. Thank you.

Hi!

This should work.

Yes this way it will work, but I thought it should be already created somewhere before.

@andrey.troeglazov

View/form configuration is not created by default for each entity type and bundle where view/form mode is available.
That's why we have this check and we create one if nothing is loaded.

Also the logs from testing patch #20 are pretty clear about the reason why it's failed.

https://www.drupal.org/pift-ci-job/1196548

Yes I know, I mean entity_get_form_display tries to load display and if can't it creates a new one.
Now I see that EntityFormDisplay::load() only loads it and not creating. Thank you. RTBC from me.

/summon @joelpittet :)

I'm looking at the creation like mentioned in #23, that doesn't seem the right place to create those, if the creation needs to happen it should happen before so we know the state going into the test, so in setUp() or elsewhere and not conditional.

This should work because it's expecting the result to assert isNew() == TRUE on the $display.

I see where you're coming from @rocket.man on the patch so thank you for doing that! The test assertion is not needed if we know we're creating it but I think it's fine to have expectations that if we create it because it's not there then that should be enough for the test. (sorry hope that make sense, explaining is a bit fuzzy at the moment)

I wonder why this started failing in 8.7 recently but I've committed it to the dev branch. Thanks for all your help!