Problem/Motivation

\Drupal\Core\Update\UpdateKernel::fixSerializedExtensionObjects() was add to fix a problem in the 8.6.7 to 8.6.8 and 8.7.0 upgrade paths. Once 8.6.x is not supported we shouldn't maintain the code. Also we should remove the test.

This is likely to be for 8.9.x because we don’t support updates from 8.6.last to 8.9.0 but it is theoretically possible to go from 8.6.last-security to 8.8.0 without losing security coverage. (Discussed this with @catch)

Proposed resolution

Remove the \Drupal\Core\Update\UpdateKernel::fixSerializedExtensionObjects() method and calls to it.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
sam152’s picture

sam152 commented

This is likely to be for 8.9.x because we don’t support updates from 8.6.last to 8.9.0

Why is that out of interest? Most of our updates are tested from 8.0.0 or 8.4.0 based on the fixtures that are available, so in theory we test update paths from really old installations. I realise this issue has a pretty trivial work-around, but explicitly not supporting upgrading old installations to $latest seems kind of unnecessary given the testing that is already in place.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented

we don’t support updates from 8.6.last to 8.9.0

I would welcome such decision, however I have to ask whether this is documented officially? Do we already remove updates introduced in branches we don't support with the new version?

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Closed (duplicate)

I mistakenly opened a duplicate of this. Normally would close the newer issue, but there's already a patch there #3130341: Remove Drupal\Core\Update\UpdateKernel::fixSerializedExtensionObjects().