Closed (fixed)
Project:
Leaflet Widget for Geofield
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
6 Feb 2019 at 16:22 UTC
Updated:
17 Feb 2019 at 11:59 UTC
Jump to comment: Most recent
Hi
I basically rewrote the whole Drupal 8 version of the Leaflet Widget module.
https://github.com/ayalon/leaflet_widget
It supports drawing of
It has
It has the same funtionality as the current version, because it also supports marker. But it uses way less frontend libraries and the code is massively reduced.
What do you think about a 2.x-dev branch? If you add me as a maintainer, I will commit the current state to the drupal.org git repo.
Comments
Comment #2
ken-g commentedHi ayalon,
You may have seen that a few days ago I made an offer to the current module maintainer (FMB) to help get the D8 version of the Leaflet Widget working by adding the Leaflet.draw plugin as the foundation for all the geometry creating and editing.
However, this afternoon I have been trying out your version of the Leaflet Widget. I can see that it is already a fully developed solution, and wouldn't take much more work to get it to a full release.
Most of my experience in this area has been with the Leaflet.draw plugin, but I have no problem using the Leaflet.PM plugin instead.
In summary, I think your version of the Leaflet Widget is great ! I would fully support making this the official widget for Leaflet for Drupal 8, and I would be happy to carry out some further testing once it is committed to drupal.org as 8.x-2.x-dev.
Comment #3
ayalon commentedThanks for the feedback and testing the new module. I will write an email to the maintainer, maybe he is willing to create a 2.x-dev branch for the module.
Comment #4
fmb commentedAwesome! I added you as maintainer for this project. You can merge your work in a 8.x-2.x-dev branch and maybe create two new releases (8.x-2.x-dev and 8.x-2.0-alpha1). Also, could you update the description on the project page?
We'll figure out later how to deal with two 8.x branches... Besides, I still have to create a new release for the 7.x-2.x branch.
Comment #5
ayalon commentedThanks for adding me as a maintainer. I created a 2.x branch and released a 2.0-alpha1 version. Additionally I updated the project page with a detailed description.
Comment #6
ayalon commentedComment #7
ayalon commentedComment #8
fmb commentedThanks!
Comment #9
ken-g commentedGood work ayalon !!
Comment #10
todda commentedthis is really awesome!!!!
Great Job!!!!!