Hitting enter on any input displays popup

#1261372: Hitting 'enter' on any input displays popup calendar
'https://www.drupal.org/files/issues/2018-06-04/webform-datepicker-126137...'

CommentFileSizeAuthor
#8 webform-datepicker-3031027-8.patch943 bytespaulvandenburg
#7 webform-datepicker-3031027-7.patch916 bytespaulvandenburg
#6 webform-datepicker-3031027-6.patch994 bytesjohankleene
#3 webform-datepicker-3031027-3.patch1015 bytesjoshahubbers
#2 webform-datepicker-3031027-2.patch798 bytesjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new webform-datepicker-3031027-2.patch798 bytes
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new webform-datepicker-3031027-3.patch1015 bytes

Previous patch did not apply in build. New version.

bskibinski’s picture

bskibinski
Primary language Dutch
Location Breda, The Netherlands
commented
Status: Active » Needs work

This patch breaks the popup calendar at the moment if you click it, it submits the form.

paulvandenburg’s picture

paulvandenburg commented
Issue summary: View changes
johankleene’s picture

johankleene commented
Status: Needs work » Needs review
StatusFileSize
new webform-datepicker-3031027-6.patch994 bytes

Created new patch for webform against 4.16. This patch applies it in Drupal voor Gemeenten.

paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new webform-datepicker-3031027-7.patch916 bytes

I've submitted a new patch to the webform issue. This patch applies that new patch.

If that webform issue is RTBC this issue is RTBC too.

paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new webform-datepicker-3031027-8.patch943 bytes

Fixed an issue with safari. See related webform issue.

paulvandenburg’s picture

paulvandenburg commented
Danny.Wouters’s picture

Danny.Wouters commented
Status: Needs review » Reviewed & tested by the community

The patch for DvG looks good .

The original problem (in the webform issue queue) is not entirely fixed for IE11 and Safari but I suggest to make this patch RBTC because there is an improvement for Chrome and Firefox

  • paulvandenburg committed 983b820 on 7.x-1.x 
    Issue #3031027 by JoshaHubbers, paulvandenburg, JohanKleene: Webform: '...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.