Error while trying to bulk delete already deleted nodes

This patch works for me. Need review

1. +++ b/core/modules/views/src/Plugin/views/field/BulkForm.php
   @@ -406,7 +406,11 @@ public function viewsFormSubmit(&$form, FormStateInterface $form_state) {
   +          \Drupal::messenger()->addError("node cannot be deleted because it doesn't exist");
   

   This should use $this->messager

2. +++ b/core/modules/views/src/Plugin/views/field/BulkForm.php
   @@ -406,7 +406,11 @@ public function viewsFormSubmit(&$form, FormStateInterface $form_state) {
   +          return $this->getDestinationArray();
   

   The early return would mean all the entities are not deleted, shouldn't we just skip the one we can't delete?

3. +++ b/core/modules/views/src/Plugin/views/field/BulkForm.php
   @@ -406,7 +406,11 @@ public function viewsFormSubmit(&$form, FormStateInterface $form_state) {
   +        } ¶
   

   trailing whitespace

Also, this needs a test

Here I have tried to address comment #5.

Hi, this is the error I got while trying to replicate

Warning: array_filter() expects parameter 1 to be array, null given in Drupal\views\Plugin\views\field\BulkForm->viewsFormValidate() (line 464 of core/modules/views/src/Plugin/views/field/BulkForm.php).
Drupal\views\Plugin\views\field\BulkForm->viewsFormValidate(Array, Object) (Line: 162)
Drupal\views\Form\ViewsFormMainForm->validateForm(Array, Object) (Line: 179)
Drupal\views\Form\ViewsForm->validateForm(Array, Object)
call_user_func_array(Array, Array) (Line: 82)
Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object) (Line: 275)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'views_form_content_page_1') (Line: 118)
Drupal\Core\Form\FormValidator->validateForm('views_form_content_page_1', Array, Object) (Line: 577)
Drupal\Core\Form\FormBuilder->processForm('views_form_content_page_1', Array, Object) (Line: 320)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 218)
Drupal\Core\Form\FormBuilder->getForm(Object, Object, Array) (Line: 2242)
Drupal\views\Plugin\views\display\DisplayPluginBase->elementPreRender(Array)
call_user_func_array(Array, Array) (Line: 100)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725', 'silenced_deprecation', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 781)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 372)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 444)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 226)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 227)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 117)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object) (Line: 156)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
No content selected.

The patch 3030989-6.patch also did not have any effect on the error displayed.

I also see the error in #7, this is also what an automated test for this shows. Updated the IS to reflect the new error.

Here is a test and a new fix for this. No interdiff because this is a whole new approach.

Patch applied cleanly and works as expected.

+++ b/core/modules/views/tests/src/Functional/BulkFormTest.php
@@ -157,6 +157,20 @@ public function testBulkForm() {
+    $this->drupalGet('test_bulk_form');
+    // Now delete the node we want to delete with the bulk form.
+    foreach ($nodes as $node) {
+      $node->delete();
+    }
+    $edit = [

It looks like we don't have coverage for the case where multiple nodes are selected, and only one is deleted?

hello @catch,

Attached is an updated patch including interdiff fixing error when multiple nodes selected but one or more but not all are already deleted. Also fixed error when multiple nodes selected and all have already been deleted. Tests to cover both cases have been added too.

Patch is re-attached for review.

Thanks @emyu01, this fixes the new tests. The error only occurs when all nodes have been deleted. The current behaviour is that when you select one node and that node doesn't exist (but there are still other nodes), you get returned to the bulk form page without any messages.

Not sure if that is the best behaviour, but it is better than a warning.

Great! thanks @Lendude.

Patch tested and looks all good.

Committed c266bb6 and pushed to 9.1.x, and cherry-picked back to 8.8.x. Thanks!