The REQUEST_TIME global constant has also been deprecated, scheduled to be removed before 9.0.0

CommentFileSizeAuthor
#2 3030738-2.patch808 bytessatyanarayan reddy

Comments

Satyanarayan Reddy created an issue. See original summary.

satyanarayan reddy’s picture

satyanarayan reddy commented
Status: Active » Needs review
StatusFileSize
new 3030738-2.patch808 bytes

The REQUEST_TIME global constant has also been deprecated.

cilefen’s picture

cilefen commented
Title: REQUEST_TIME is deprecated » Replace usages of the deprecated REQUEST_TIME constant
Version: 8.6.x-dev » 8.7.x-dev
Component: user.module » base system
Status: Needs review » Needs work

Hello. Thanks for the patch. We do not usually commit changes like this that are specific to one module. I am re-titling this issue as "Replace usages of the deprecated REQUEST_TIME constant".

Let's replace all of them.

It won't be trivial. To replace in one module is too small of a scope, but to change all of them in one patch may be too "big"—there are ~350 usages in core. We in fact may wish to break this down a bit, perhaps by splitting into an issue to replace usages in tests, another for modules, and another for lib.

Thanks for taking this up!

satyanarayan reddy’s picture

satyanarayan reddy commented

I was created patch for test and Module
Reference url
1) https://www.drupal.org/project/drupal/issues/3030999
2) https://www.drupal.org/project/drupal/issues/3030983

cilefen’s picture

cilefen commented
Title: Replace usages of the deprecated REQUEST_TIME constant » [meta] Replace usages of the deprecated REQUEST_TIME constant
Status: Needs work » Active

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Related issues: +#3112283: Replace REQUEST_TIME in non-OO and non-module code

See possibly related issues noted here:

https://www.drupal.org/project/drupal/issues/3112283#comment-13605217

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

megachriz’s picture

megachriz
Primary language Dutch
commented
Related issues: +#2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service

There is an other meta issue for this too #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Closed (duplicate)

Other issue is fixed #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service