Hi,

There should be validation for Publish Date and Expiry Date. The values in the fields should not be the same.
It's accepting the same values.

Scenario:
Suppose you have set up an event block starts at 4/2/2019 18:45:00 and it will get over at 4/2/2019 18:45:00.
Technically, there must be the time difference. So that user won't keep the same value for start & end date.

Suggestion:
Add validation before block gets submit.

Checked the attached file: block_scheduler.png

Thanks and Regards,
Mayank

CommentFileSizeAuthor
#3 block-schedular-review.png53.6 KBsdxt
#2 validation_code-3030475-2.patch723 bytespatelmayank7552
block_scheduler.png30.15 KBpatelmayank7552

Comments

patelmayank7552 created an issue. See original summary.

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
StatusFileSize
new validation_code-3030475-2.patch723 bytes

Hi,

I have created the patch to fix this issue.

Please review it.

Thanks

sdxt’s picture

sdxt commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new block-schedular-review.png53.6 KB

Hi @patelmayank7552, I have applied the patch and found it working, now user has to enter end date greater than the start date.
Please find the screenshot.

  • geoanders committed f0c6b3a on 2.0.x 
    Issue #3030475 by patelmayank7552, sdxt: Validation needed for Publish...
geoanders’s picture

geoanders commented
Status: Reviewed & tested by the community » Fixed

Now fixed in 2.0.x branch. I had to adjust the code to make sure we had date values and that the returned value from form state was indeed an object and not an array.

geoanders’s picture

geoanders commented
Status: Fixed » Closed (fixed)