CommentFileSizeAuthor
#6 interdiff_3030256-6.txt1.89 KBsam2de
#6 3030256-2.patch5.5 KBsam2de
#2 mailgun-mailing_list_subscribers_list-3030256-2-D8.patch4.87 KBartem_sylchuk

Comments

james_kerrigan created an issue. See original summary.

artem_sylchuk’s picture

artem_sylchuk
Primary language Ukrainian
Location Lutsk
commented
Assigned: artem_sylchuk » Unassigned
Status: Active » Needs review
StatusFileSize
new mailgun-mailing_list_subscribers_list-3030256-2-D8.patch4.87 KB

Attached patch adds new column to the list table which has a link to the members list.

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented
Status: Needs review » Needs work

Can we please add logging/message to the catch block?
Thanks.

sam2de’s picture

sam2de commented 
+++ b/modules/mailgun_mailing_lists/src/Controller/MailingList.php
@@ -0,0 +1,84 @@
+  public function members($list_address) {

The "members()" method is not being used. Is there any need for it? If not I'm happy to remove and submit a patch for it.

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented

Hi @sam2de, the members() method is a controller callback and it's required.
You may want to update the patch to add logging if you're willing to support this issue.

sam2de’s picture

sam2de commented
Status: Needs work » Needs review
Issue tags: -LutskGCW19 +Seattle2019
StatusFileSize
new 3030256-2.patch5.5 KB
new interdiff_3030256-6.txt1.89 KB

Added the logger message and Updated the return markup. Interdiff file included as well.

@abramm, my bad I missed checking the router definition.

sam2de’s picture

sam2de commented

@abramm, Previous patch fails because it running against the dev branch not "8.x-2927836-Mailgun-lists" branch. I think this could be resolved by merging 8.x-2927836-Mailgun-lists into the dev branch

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Issue tags: +LutskGCW20
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs review » Fixed

Thanks a lot!

It was committed and pushed to 8.x-2927836-Mailgun-lists branch.
I'm gonna do a clean-up and merge it to 8.x-1.x soon, stay tuned.

  • Matroskeen committed e0e4053 on 8.x-1.x authored by sam2de 
    Issue #3030256 by sam2de, james_kerrigan, abramm: Mailgun lists > List...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.