Problem/Motivation

The Mailgun client should be re-usable by other (sub-)modules.

Proposed resolution

Instead of passing the config factory to the mailgun handler service, we may create a new 'mailgun client' service and pass the API key from configuration to it.
This way we'll use Drupal's container to instantiate a Mailgun client for us.

Remaining tasks

Implement service definition (and maybe a client factory?).
Update mailgun_handler service definition to use a client injected with DI.

User interface changes

None.

API changes

A new service will be added.

Data model changes

None.

CommentFileSizeAuthor
#5 mailgun-mailgun_client_service-3030226-3-D8.patch2.62 KBartem_sylchuk
#3 mailgun-mailgun_client_service-3030226-2-D8.patch2.62 KBartem_sylchuk

Comments

abramm created an issue. See original summary.

artem_sylchuk’s picture

artem_sylchuk
Primary language Ukrainian
Location Lutsk
commented
Assigned: Unassigned » artem_sylchuk
artem_sylchuk’s picture

artem_sylchuk
Primary language Ukrainian
Location Lutsk
commented
Status: Active » Needs review
StatusFileSize
new mailgun-mailgun_client_service-3030226-2-D8.patch2.62 KB

Please take a look

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented
Assigned: artem_sylchuk » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good for me; also I can confirm I've seen these changes working during the code sprint seesion. Let's wait for unit test results thought.

artem_sylchuk’s picture

artem_sylchuk
Primary language Ukrainian
Location Lutsk
commented
StatusFileSize
new mailgun-mailgun_client_service-3030226-3-D8.patch2.62 KB

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Reviewed & tested by the community » Fixed

Awesome! Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.