Now that Zurb Foundations has had a 6.5+ release since October 30th 2018 and Motion-Ui has had a 2.0+ release since June 7, 2018 I think it is time to track towards a point release with these updates on this theme.

Most notably there are many performance and browser support improvements that all new builds should be working from.

Zurb was a bit quiet for most of 2018, but in the first several weeks of 2019 we have seen several point releases on both projects which means there much welcomed movement and a good reason for us to start working on the upgrade path

Comments

philosurfer created an issue. See original summary.

hongpong’s picture

Good point. Question, if the new release notes "UMD, CJS, ESM and ES6 Bundles!" does this affect our custom JS?

release notes here
https://medium.com/@ncoden/foundation-6-5-0-released-f405d8561ed7

also since this is supposed to have backwards compatibility we would likely want to stay on 8.x-6.x branch here i agree.

Perhaps a new alpha release should be tagged with the current version, then we tackle the long standing issues with layouts aligned with a 6.5 release eg #2867688: compatibility problem with drupal-8.3.0 and ds-8.x-3.x . that seems like a way out of the problems?

philosurfer’s picture

@hongpong I will take a look with my team members this week and see if we cannot get a patch pushed out. :^)

There only seems to be minor breaking changes for motion-ui per the official Zurb.com release note links in my OP. Foundation-sites explicitly is backward compatible with 6.4.4-RC1. (woot!)
(Note: I refuse to use Medium.com as the source of truth for anything)

Current notables:
- jQuery is now a jquery@>=2.2.0 Peer dependency for motion-ui. This causes *npm install* (lando npm install, if you are cool ;^) to throw a warning. This should not be an issue as D8 seems to be using jQuery v3.2.1 out of box. We need to figure out how to make NPM aware of jQuery in core.
- Updating package.json in drupal/zurb_foundation (patch forthcoming) seems to not break anything at this point. I will have my team review the current custom JS code to fix any breaking changes and update for optimization and use of xy-grid (where Zurb is going moving forward)

hongpong’s picture

philosurfer that is excellent, i think i can do some tests for you in about the next 2 weeks because i would like to have this in before I start another project. I looked around quite a bit and could not figure how to work around the NPM / jQuery thing you mention. Tricky!

jaarong’s picture

I have moved to 6.4 using the XY grid using the patch from https://www.drupal.org/project/zurb_foundation/issues/2895757

I would also be interested in this and willing to do some testing on my site. I am basically using 6.5.3 css now, and using the JS in the base Foundation theme with the patch.

philosurfer’s picture

OC removed.

philosurfer’s picture

StatusFileSize
new4.17 MB

First swipe at a patch.

So far we have found nothing in the "custom JS" that the zurb_foundation theme provides.
Still waiting on final confirmation on that statement from my dev team.

Attaching this patch for now so my builds have these changes :^)

kclarkson’s picture

Thanks for everyone working on this! Would love to be running a more updated version of Zurb.

steveoriol’s picture

Patch #7 works for me, installed over 4 web sites.
There is just need to postpone the changes to the "package.json" file in already created subthemes and make a "npm install" then a "gulp" to update, cool ;-)
The changes:

    "foundation-sites": "~6.5.3",
    "motion-ui": "~2.0.3",
    "what-input": "^4.3.1",
sim_1’s picture

Status: Needs work » Needs review

I've applied this on a current 8.x-6.x branch and it worked for me. I think this is a worthwhile change to address so that new sites get to use the latest versions of Foundation.

Maybe, as time allows, this could be reviewed by a maintainer and we could see what issues or risks need to be resolved for this to be included in future builds. I'm marking at as Needs Review for that reason.

erutan’s picture

Status: Needs review » Reviewed & tested by the community

This has been working for me as well, given non-breaking patch notes and the fact that I'm the third person I'll set as RBTC. :)

sim_1’s picture

That's good, thank you for doing that erutan. One new development related to this branch is that Zurb Foundation has a new 6.6.1 build. Since this patch has been tested and reviewed it seems to me like we could just work on getting this patch accepted and then worry about another patch to move it up to 6.6.1. But I also see the benefit (and I like the directness) of just updating this patch to use the latest version of ZF. Other thoughts?

philosurfer’s picture

Let's focus that on a separate ticket and PR, as there are number of things that need to be reviewed for breaking changes.

ocastle’s picture

Also confirm this patch is working with v6.5.3.

I've created a new issue for an upgrade to 6.6.1 - 3109917

sim_1’s picture

Great, thanks for doing that ocastle!

Ok, one more question since this is such a big breaking patch: Where are we keeping track of upgrade steps so that when the next release is tagged we have the information needed to put together the release notes?

hongpong’s picture

I have made note of this issue on the 6.x plan at #2655142: 8.x-6.x Roadmap and note about #3109917: Upgrade to Foundation 6.7.4. The plan issue may be a logical place to collect these upgrade step notes. (I'm not insisting on it but it's the most logical place I can think of right now). Thanks for working on this - my previous dev environment took a dive and I haven't been able to run thru these changes.

sim_1’s picture

Ok, I'm going to work on merging this today. One thing I might want to add to the module overview page is a note that if people are using the dev version of the branch (because I think there are a number of people who use it), to refer to the roadmap issue for comments and update notes because updating the dev version will without-fail break their subthemes if they don't follow the manual steps.

  • sim_1 committed 1d3e65c on 8.x-6.x authored by philosurfer
    Issue #3029876 by philosurfer, sim_1, HongPong, jaarong, kclarkson,...
sim_1’s picture

Status: Reviewed & tested by the community » Fixed

Thank you philosurfer for making this patch, and everyone for testing it and talking it through! Hopefully this gets us over the hurdle of some of the scary breaking changes so we can keep moving towards the next release.

hongpong’s picture

Thanks so much, that is excellent!!

ocastle’s picture

Great work! Cheers everyone.

steveoriol’s picture

;-) Well done !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.