Problem/Motivation

Block layout page currently has a regular select element on the region selection. However, the design system uses small select varation for this element.

https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Design-system?node-i...

Proposed resolution

Use the small variation of select for the region selection in the block layout page.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 claro-dropdown-after.png62.54 KBbrightbold
#7 claro-dropdown-before.png55.74 KBbrightbold
#5 3029683-use-small-select-5.patch490 bytesjds1
#2 Block-layout-select.png11.65 KBhuzooka
#2 Small-select.png18.37 KBhuzooka
#2 Default-select.png22.58 KBhuzooka

Comments

lauriii created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new Default-select.png22.58 KB
new Small-select.png18.37 KB
new Block-layout-select.png11.65 KB

Well, it's a third version.

See the attachments.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: +#2417111: Replace container-inline with form--inline to display forms horizontally.
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: -#2417111: Replace container-inline with form--inline to display forms horizontally.

No, this isn't related.

jds1’s picture

jds1
he/they
Location Hudson Valley, NY
commented
StatusFileSize
new 3029683-use-small-select-5.patch490 bytes

I added some code to the select preprocess in claro.theme that checks if the select element is the region selector and adds the small class. Patch attached.

jds1’s picture

jds1
he/they
Location Hudson Valley, NY
commented
Status: Active » Needs review
brightbold’s picture

brightbold
she/her
Primary language English
Location Boston, MA
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new claro-dropdown-before.png55.74 KB
new claro-dropdown-after.png62.54 KB

Both the patch and its results look good to me.

Before:
Claro bl0ck layout page with large select form inputs

After:
Claro block layout page with small select form inputs

  • lauriii committed 793fab8 on 8.x-1.x 
    Issue #3029683 by if-jds, huzooka, BrightBold, lauriii: Use small select...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Looks good. Thank you everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.