Problem/Motivation

After talking with @alexpott we've noticed on #3028319: Specialized entity interfaces should extend the main EntityInterface that @WimLeers commented for the first time after the patch has been committed and the issue put into the status "fixed", but still has received a credit.

Proposed resolution

Don't give credits after the issue has been resolved.

However we should consider that an issue might get reverted and new contributors might start commenting as well before the issue goes into the "fixed" status for a second time.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

hchonov created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
commented
Title: People get credit for commenting on fixed issues » People appear to get credit for commenting on fixed issues
Related issues: +#2978223: Issue credit form looks to non-maintainers like they could do something with it but they in fact can't, +#2972225: Move from opt in to opt out for contribution attribution

Credit is not assigned and added to a user’s profile until a maintainer comments. While the checkbox was checked, credit was not actually assigned until alexpott commented.

The credit defaults changed yesterday with #2972225: Move from opt in to opt out for contribution attribution. So what you see is like if Wim uploaded a patch to that fixed issue, the default is now to have maintainers assign credit for any comment, not just file uploads.

Maybe when an issue is fixed, the display should switch to only show assigned credit. Or further UI affordances to show what exactly is going on to maintainers vs non-maintainers #2978223: Issue credit form looks to non-maintainers like they could do something with it but they in fact can't.

  • drumm committed 19bbff2 on 7.x-3.x, dev 
    Issue #3029478 by hchonov, drumm, B_man: People appear to get credit for...

drumm credited B_man.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Fixed

Now when an issue is marked as fixed or closed/fixed, no additional credit is suggested. Only credit that has been assigned by the maintainer is shown on issue pages.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.