I'm no advanced CSS freak, so I can't easily fix that, however when I add a "Global: Dropbutton" field to a view and don't set a long enough label, t is being pushed out of the table. Same happens if the Dropbutton is in another column: column size is minimal, so overlapping the neighboring column.
| Comment | File | Size | Author |
|---|---|---|---|
| #53 | 3029468-d11-global-dropdown.png | 188.87 KB | nayana_mvr |
| #53 | 3029468-d11-multiple-fields.png | 339.73 KB | nayana_mvr |
| #53 | 3029468-d11-single-field.png | 324.38 KB | nayana_mvr |
| #52 | Bulkdrop multi field.png | 131.81 KB | akashdab |
| #52 | Normal drop multi field.png | 128.39 KB | akashdab |
Comments
Comment #5
poojakural commentedComment #6
poojakural commentedComment #7
rohit tiwari commentedComment #8
rohit tiwari commentedThe issue exists only when there is single option in drop-button field. Works fine with multiple option. Have created a patch to fix this for single optioned drop-button.
Comment #9
rohit tiwari commentedComment #10
lendudeSince the current fix is not in Views, I'm moving it out of Views and into the generic CSS component.
We should ideally have some before/after screenshots. Also screenshots from a use case outside of a Views table to show that this is still looking good.
Comment #11
rohit tiwari commentedThanks for the suggestion @Lendude,
Attaching screenshots inside and outside view table, before and after applying patch.
Comment #12
rohit tiwari commentedComment #13
Rkumar commentedAs per screenshot changes seem fine, can we check/verify with the other core themes as well?
Comment #14
lendude@Rohit Tiwari thanks for those!
+1 on #13
As the non-views screenshots in #11 show, the whitespace around the content of the rows changes. It gets more padding/margin than before the patch, which sounds like an unwanted change.
Comment #15
poojakural commentedComment #16
poojakural commentedI have checked the issue with select and multiselect dropwdown. Not able to find the issue. Dropwdown button is not going out of the table. Please refer the SS.
Step to test:
1. Create a view page
2. Add fields
3. Then add global dropdown field. select field you want to show in dropdown.
4. Check with single select and miltiselect dropdown field.
Comment #17
poojakural commentedComment #18
lendudeNeeds work for the regression in #14
@poojakural "Not able to find the issue. Dropwdown button is not going out of the table." Is that with or without the patch applied? On which version of Drupal core? Since the screenshots in the issue summary show the problem quite clearly.
Comment #19
poojakural commented@Lendude I have checked the issue without applying patch. Not able to replicate the issue. I am using this drupa1 version attached SS
Comment #20
poojakural commentedComment #21
lendude@poojakural per the title of this issue: "if no label set", in your screenshots you do have a label set for that column. So they are a good test case for this only happening when no label is set :)
Comment #22
poojakural commentedFixed single dropbutton issue. Tested on Bartik, Stable, Claro, Stark. Seven themes.
Step to test:
1. Create a view page
2. Add fields
3. Then add global dropdown field. select field you want to show in dropdown.
4. Check with single select and miltiselect dropdown field.
Please refer the SS and patch.
Comment #23
Rkumar commentedFew observations -
=>
Why in this file?
=> Don't you think it must have solution wrt all core themes
Comment #24
poojakural commentedComment #25
poojakural commentedPlease refer the attached patch. Single dropdown issue found in bartik and seven. Dropbutton is working finr in rest of the themes.
Comment #26
poojakural commentedComment #27
priyanka.sahni commentedWorking on it
Comment #28
priyanka.sahni commentedVerified and tested by applying the patch #25.Getting error while applying patch on Drupal 9.1.x whereas patch was applied successfully on Drupal 9 and issues exists with Bartik and Seven theme.Patch #25 should be re-rolled for Drupal 9.1.x
Steps to test -
1. Go to the admin site.
2. Go to admin/structure/views/view/content.
3. Edit a view page.
4. Add fields.
5. Then add global dropdown field. select field you want to show in dropdown and leave label as blank.
6. Check with single select and multi - select dropdown field.
After Patch D.9.1.x -
After Patch D.9 -
Comment #29
komalk commentedThis issues exists with Bartik and Seven theme. Tested patch #25 is not working for me after applying patch issue still exit in outside the view.
/core/modules/views_ui/css/views_ui.admin.theme.csschanging the code in this file not work the outside view table.Here is the fixed review the patch attached screen shot for the reference.
Comment #30
pankaj.singh commentedThe issue "Drop button field pushed out of the table if no label set" is occurring on Bartik and Seven themes only.
Tested the patch given in #25, patch applied on my end on 9.1.x and patch fixed the issue. Please refer to SS attached for ref.
@priyanka.sahni the error you're getting with the patch while applying on 9.1.x probably because the last patch you applied was not made reset on your end.
Comment #31
pameeela commentedRemoving the tag as we definitely do not need anymore screenshots for this issue!
Comment #32
pameeela commentedComment #34
djsagar commentedHi,
Patch is working on drupal9.1.
Rolling up patch for drupal9.2.x-dev.
Please review
Thanks!
Comment #35
abhijith s commentedApplied patch #34 and it works fine.Adding screenshots below.
Before patch:
After patch;
Comment #39
Shubham Sharma 77 commentedApplied patch #34 applied successfully in drupal-9.5.x-dev. Good to move for RTBC.
Thanks for the patch
For ref sharing screenshots...
Comment #40
ramenkageI just ran into this issue on a site, and Patch #34 introduced some undesirable visual behavior by setting fixed-width columns on the table. I came up with a different solution, included here.
The way dropbuttons are handled in tables isn't particularly elegant as the CSS just assumes a width for the button. I think completely revamping that would be out of scope for this issue.
For now, I simply added CSS for
.dropbutton-singleto make it consistent with.dropbutton-multiple, reducing the padding by the width of.dropbutton-toggle.Comment #41
pradipmodh13 commentedPatch #40 was successfully applied.
Admin Theme: Seven for Drupal 9.5X
Please see the accompanying screenshot.
It's a good move, RTBC.
Thanks
Note: For testing purposes, I used Bartik and the default admin theme. It is fully operational.
Comment #43
gaurav-mathur commentedComment #44
gaurav-mathur commentedI have tested the issue without applying any patch & not able to get the issue.
I am using this drupa1 10.0.x-dev version, tested with claro theme.
Refer to screenshots.
Comment #45
gaurav-mathur commentedComment #46
smustgrave commentedFYI once one set of screenshots is added additional screenshots are duplicative work.
Reviewing the patch believe we are trying to get away from using dir="rtl"
Tried testing on claro but I didn't see the issue. Maybe additional steps should be added?
Comment #47
sonam.chaturvedi commentedI also tried testing on both claro and seven themes, however issue is not reproducible on 10.1.x-dev.
Comment #49
shweta__sharma commented#46 and #47 were unable to replicate the issue so adding a tag
Comment #50
shweta__sharma commentedAdded standard IS template which was missing.
Comment #51
akashdab commentedThe issue of Global dropdown getting pushed out of the table does not seem to be reproduced in 11.x, but new issues has taken its place altogether.
Steps taken to reproduce the issue taken from #28.
(Edited out content as images did not appear)
Comment #52
akashdab commentedThe new issue that seem to appear are :
1. If single field dropdown is selected,
a. It follows standard when text character length is normal without too much spacing.
b. It follows standard when text character length is not normal without any spacing between words in dropdown button
c. It does not follow when text character length is long and has spacing between words.
2. In multi field dropdown selection,
a. It follows proper spacing standards in relation to other table rows only when
Content: Node operations bulk formis selectedBulk form view:
Bulk form dropdown open:
b. It breaks standard view if any other field besides
Content: Node operations bulk formis selected and when the first field contains anything unique such as Title, Author NameStandard redirect dropdown broken view:
Transparent dropdown broken view:
c. It breaks standard view when any field that cannot be redirected is selected; these fields are visible with a transparent bg, without following any spacing, positioning standards. Similarly if fields that can be redirected appear they appear normally.
Normal drop multi field:
Bulkdrop multi field:
Comment #53
nayana_mvr commentedThe original issue mentioned in this ticket
is not reproducible in Drupal version 11.x. Attaching screenshots for reference.
But as mentioned in #52, there are UI issues when a field which cannot be redirected is added in the Global dropdown (SS can be referred in #52).
In the Global dropdown configuration, all the fields which are added in the view are listed down as options for global dropdown items. Also, there is a help text saying "Fields to be included as links." which doesn't make sense because fields such as Content Type, Status, Updated, etc doesn't have any link to redirect, so why do we have to show those fields as an option for global dropdown? Also Operations field which is already a dropdown should not be allowed as an item in another dropdown right? (I'm checking this in
/admin/structure/views/view/content)Please correct me if I'm getting this wrong. If we need to work on dropdown style, then I think it should be tracked in a different ticket since the original issue of this ticket is already fixed in D11. Marking this as Needs Review for feedback from others.
Comment #54
smustgrave commentedIssue summary still appears to be incomplete/incorrect.
No steps to reproduce
No proposed solution
Broken images in release notes (this doesn't need release notes as it's not a major change)