API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Datetime%...

Enter a descriptive title (above) relating to class DrupalDateTime, then describe the problem you have found:

> * @see \Drupal/Component/Datetime/DateTimePlus.php

The slashes can't decide which way they're going!

Also, typically we link to code components such as classes, methods, or functions, rather than files.

CommentFileSizeAuthor
#6 Broken-@see-3029350-6.patch521 bytesdhirendra.mishra
#2 3029350-2.patch531 bytesgovind.maloo

Comments

joachim created an issue. See original summary.

govind.maloo’s picture

govind.maloo commented
Status: Active » Needs review
StatusFileSize
new 3029350-2.patch531 bytes
joachim’s picture

joachim commented
Status: Needs review » Needs work

Thanks for the patch!

+++ b/core/lib/Drupal/Core/Datetime/DrupalDateTime.php
@@ -16,7 +16,7 @@
+ * @see \Drupal\Component\Datetime\DateTimePlus.php

However, that's neither a class name (because it's got the .php extension) or a filename (wrong type of slash).

nginex’s picture

nginex commented
Issue tags: +LutskGCW19
dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: Unassigned » dhirendra.mishra
Issue tags: +ContributionWeekend2019

we will work on @ContributionWeekend2019

dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Broken-@see-3029350-6.patch521 bytes

Here is the correct patch.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs review » Reviewed & tested by the community

Patch looks fine

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.6.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed affa4ca and pushed to 8.7.x. Thanks!

  • catch committed affa4ca on 8.7.x 
    Issue #3029350 by dhirendra.mishra, govind.maloo, joachim: broken @see...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.