Problem/Motivation

use short array

CommentFileSizeAuthor
#5 mailsystem-use_short_array-3029285-5-D8.patch30.36 KBthalles
#2 mailsystem-use_short_array-3029285-2-D8.patch22.14 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new mailsystem-use_short_array-3029285-2-D8.patch22.14 KB

Follow the path!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
manuel garcia’s picture

manuel garcia commented
Title: Use short array » Use short array syntax
Status: Needs review » Needs work

Thanks, patch looks good, let's also update the code blocks on the README files:

                README.html  (4 usages found)
                    79 array(
                    80 mailsystem_default_id() => array(
                    91 array(
                    92 mailsystem_default_id() => array(
                README.txt  (4 usages found)
                    86   array(
                    87     mailsystem_default_id() => array(
                    99   array(
                    100     mailsystem_default_id() => array(
                README.markdown  (4 usages found)
                    91       array(
                    92         mailsystem_default_id() => array(
                    102       array(
                    103         mailsystem_default_id() => array(
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new mailsystem-use_short_array-3029285-5-D8.patch30.36 KB
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
manuel garcia’s picture

manuel garcia commented
Status: Needs review » Reviewed & tested by the community

Thanks @thalles for following up on this, I had a look locally and everything seems correct now.

manuel garcia’s picture

manuel garcia commented
Status: Reviewed & tested by the community » Fixed

Verified with @Bedir over slack and committed - thanks!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.