In the D7 version of Feeds, you could configure a feed to run in the background (during cron runs) instead of in the UI. This is useful if you have a large feed to import and don't want to keep the browser open until the import has finished.
Let's add a new operation called "Schedule import" that will live beside the 'Import' operation. Now an user can choose whether he/she wants to import directly or wait until cron has ran.
Review.
On the feed page a new button called "Schedule import" appears.
On the feed listing page an operation called "Schedule import" is added to the dropbutton.
None.
New permissions will be added for scheduling imports. You could configure this way whether your users are allowed to import directly or import in background.
Patch will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff-3029133-3-5.txt | 652 bytes | megachriz |
| #5 | feeds-schedule-import-3029133-5.patch | 12.17 KB | megachriz |
Comments
Comment #2
megachrizDepends on #3028959: Errors when viewing feed listing page with limited privileges, which was just committed.
Comment #3
megachrizThis renames the button to "Import in background". Hopefully, this label makes it more clear for first time users what the button does compared to the default "Import" button.
I also added some help texts. I hope these are useful.
Dynamic label?
I received the suggestion to rename the default button to "Import now", but I think I will leave it to what it is: "Import". I had the idea to dynamically rename the button to "Import" if you only would see one of the two actions. For this, I started to follow the instructions on https://www.drupal.org/docs/8/api/menu-api/providing-module-defined-loca..., but then I wasn't sure how to properly reach the feed type in
::getTitle()and got worried about possible caching issues. So I decided to keep it simple.Comment #5
megachrizThe test failed because since the text for the action "Schedule import" was changed to "Import in background", the test found the text "Import" as well. It was asserted that that text should not be available.
Removing that line.
Comment #7
megachrizCommitted #5.