Thank you for the patch - I appreciate the work. But it does not apply to the current version of the module.

CommentFileSizeAuthor
#13 3029064-13.patch2.67 KBneslee canil pinto
#10 typo-3029064-10.patch3 KBwatergate
#9 3029064-9.patch1.09 KBsuresh prabhu parkala
#7 typo-3029064-7.patch2.14 KBwatergate
#6 typo-3029064-6.patch2.18 KBwatergate
#2 typo-3029064-2.patch695 bytesmithun s

Comments

Gribnif created an issue. See original summary.

mithun s’s picture

mithun s
Primary language English
Location Bangalore
commented
Status: Active » Needs review
StatusFileSize
new typo-3029064-2.patch695 bytes

Typo error fixed in VendorFileDownloadController.php file.

gribnif’s picture

gribnif commented
Status: Needs review » Reviewed & tested by the community
jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Closing as duplicate of: https://www.drupal.org/project/vendor_stream_wrapper/issues/3029055

Thank you for reporting.

xsramik’s picture

xsramik commented
Version: 8.x-1.x-dev » 8.x-1.3
Issue summary: View changes
Status: Closed (duplicate) » Active

I see that typo is still present in 1.3.0 (so I guess not fixed in 8.x-1.x-dev either). It also seems to not be a duplicate as stated in #4.

watergate’s picture

watergate commented
Title: Typo in VendorFileDownloadController.php exception handler » Typo fixes and applied Drupal coding standards
Version: 8.x-1.3 » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new typo-3029064-6.patch2.18 KB

I can confirm that it is not a duplicate of #3029055. I have extended the patch with additional typo fix (file name in the tests directory) and applied Drupal coding standards (i.e., missing doc comment and added core_version_requirement: ^8 || ^9 to make the module Drupal 9 ready).

It would be great if someone could review the patch :)

watergate’s picture

watergate commented
StatusFileSize
new typo-3029064-7.patch2.14 KB

Patch didn't apply correctly (the 'core' property in the .info.yml is rewritten automatically).

jaypan’s picture

jaypan
Location Victoria, BC
commented
Issue summary: View changes
Status: Needs review » Needs work
suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3029064-9.patch1.09 KB

Please review!

watergate’s picture

watergate commented
StatusFileSize
new typo-3029064-10.patch3 KB

I've updated the patch and tested it with the current version of the module.

xsramik’s picture

xsramik commented

I tested patch (#10) on D8.9.2, works well! I tried it as well on D9.0.2, but composer seems to first check the compatibility before it applies the patch. As I don't pass compatibility (with D9 site), I can't test it there.

Looking forward for release to be able to use it with Drupal 9!

Status: Needs review » Needs work

The last submitted patch, 10: typo-3029064-10.patch, failed testing. View results

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
StatusFileSize
new 3029064-13.patch2.67 KB

Fixed the tests

  • Neslee Canil Pinto committed 9195a9d on 8.x-1.x 
    Issue #3029064 by Watergate, Neslee Canil Pinto, Mithun S, Suresh Prabhu...
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Fixed

Committed to dev branch. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.