Follow-up from #3026851-3: Support multilingual SVG logos for branding block

Additional testing around this revealed that `height: auto` CSS rule coming from bs_bootstrap/sass/components/partials/_navigation.scss:

// Inline SVG logo.
.site-logo-link--svg {
  svg {
    // SVG logo should respect parent dimension.
    max-width: 100%;
    height: auto;
  }
}

Is causing problems in IE11 and also it seems that this rule is not needed for other browsers.

Let us remove `height: auto;` line and add into documentation that for SVG logo version you must use width and height attributes in SVG tag if you want to support IE11.

Comments

pivica created an issue. See original summary.

pivica’s picture

Status: Active » Needs review
StatusFileSize
new446 bytes

Here is a patch. Documentation also created on https://www.drupal.org/docs/8/themes/bs-base/additional-features/svg-logo..

pivica’s picture

Issue tags: +next-point-release-merge

  • pivica committed e0cffcd on 8.x-1.x
    Issue #3028942 by pivica: Remove height auto rule for SVG logo
    
pivica’s picture

Status: Needs review » Fixed
Issue tags: -next-point-release-merge

Improved a comment a bit, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.