While testing the latest dev release I'm getting this error on syncing: Warning: array_key_exists() expects exactly 2 parameters, 1 given in Drupal\salesforce\SelectQuery->__toString() (line 82 of [path to module]/salesforce/src/SelectQuery.php), which was committed here: https://cgit.drupalcode.org/salesforce/commit/?id=f7bbaef

The array_key_exists() call is looking for a second array parameter. Can we use isset() instead to check there? Changing to isset() instead is working for me and allowing field properties to sync.

CommentFileSizeAuthor
#3 salesforce-select_query_array_key_warning-3027846-3.patch920 bytesaaronbauman
#2 3027846-1.patch542 bytestjhellmann

Comments

tjhellmann created an issue. See original summary.

tjhellmann’s picture

tjhellmann
he/him
Primary language English
Location Indianapolis, IN
commented
StatusFileSize
new 3027846-1.patch542 bytes

Patch attached.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new salesforce-select_query_array_key_warning-3027846-3.patch920 bytes

Good catch. I think this is a bit cleaner

tjhellmann’s picture

tjhellmann
he/him
Primary language English
Location Indianapolis, IN
commented

Yes, that's better, and works to remove the error and have field property syncing work again. Thank you.

acrosman’s picture

acrosman
Primary language English
Location South Carolina, US
commented
Status: Needs review » Reviewed & tested by the community

Patch in #3 works for me. Sorry original bug is my bad.

  • aaronbauman committed 0e09d56 on 8.x-3.x 
    Issue #3027846 by tjhellmann, aaronbauman: PHP Warning from...
aaronbauman’s picture

aaronbauman
he/him
commented
Status: Reviewed & tested by the community » Fixed

OK, this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.