Reported by @effulgentsia at #2843147-102: Add JSON:API to core as a stable module.
This went unnoticed due to Drupal.org's QA configuration being utterly broken: I had configured PHP 5.6 + Drupal 8.5 to be one of the configurations to test, but it keeps overwriting/changing it…
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3027501-7.patch | 2.2 KB | wim leers |
| #7 | interdiff.txt | 1.31 KB | wim leers |
| #3 | 3027501-3.patch | 944 bytes | wim leers |
| #2 | 3027501-2-ONLY_WHITESPACE_CHANGES.patch | 824 bytes | wim leers |
Comments
Comment #2
wim leersComment #3
wim leersSame problem reproduced. Great.
Now let's fix it.
Comment #4
wim leersThis regression was introduced in #2995960: Add a Link and LinkCollection class to support RFC8288 web linking..
Comment #5
wim leersComment #6
wim leersGreen on 5.6! Now also queueing a PHP 5.5 test, just to make sure.
Comment #7
wim leersHah. #2992833: Add a version negotiation to revisionable resource types introduced a regression too. One caused by the nicer PHP syntax that
\Drupal\jsonapi\JsonApiSpec::isValidMemberName()refrained from using precisely because PHP 5.6 is not yet a requirement.Comment #8
wim leers✅ on 5.5, 5.6, 7.0. Let's do this.
Just one nit:
s/tot/to/
Comment #9
wim leersComment #11
wim leersd.o, you're drunk.