As a followup of #3020493: Module not working on Drupal 8.6 the patch https://www.drupal.org/files/issues/2018-12-14/cbb-refactoring.patch needs

  • reroll to be apply
  • code needs some feedback review from ardkuijpers.
CommentFileSizeAuthor
#3 cbb-remove-settings-copy-3027336-3.patch1.99 KBclemens.tolboom
#2 cbb-remove-settings-copy.patch3.48 KBardkuijpers

Comments

clemens.tolboom created an issue. See original summary.

ardkuijpers’s picture

ardkuijpers commented
Title: Refactoring code » Remove necessity to copy settings
Status: Active » Needs review
StatusFileSize
new cbb-remove-settings-copy.patch3.48 KB

The purpose of the refactoring was to remove the necessity to copy the settings block in cbb_block_view_alter and use that copy in _cbb_block_view_alter_pre_render. The settings are now directly retrieved (via the Block::load).

I have included a new patch file for this refactoring.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
StatusFileSize
new cbb-remove-settings-copy-3027336-3.patch1.99 KB

Weird the patch shows wrong on my side.

$ git apply ~/Downloads/cbb-remove-settings-copy.patch 
error: unrecognized input

So I https://www.drupal.org/files/issues/2019-01-22/cbb-remove-settings-copy.... then copied text.

vi ~/Downloads/cbb-remove-settings-copy-3027336-3.patch
$ git apply ~/Downloads/cbb-remove-settings-copy-3027336-3.patch
error: patch failed: cbb.module:30
error: cbb.module: patch does not apply

Not sure why/what. I see mixed spaces and tabs in VS Code editor.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

It seems to work OK so committing

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.