Problem/Motivation

Drupal asked for dependency injection of Drupal\Core\Asset\LibraryDiscovery

Proposed resolution

Inject service library.discovery

CommentFileSizeAuthor
#11 blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-11-D8.patch2.56 KBthalles
#8 blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-8-D8.patch19.21 KBthalles
#5 blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-5-D8.patch1.92 KBthalles
#2 blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-2-D8.patch1.93 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-2-D8.patch1.93 KB

Follow the patch!

gausarts’s picture

gausarts commented
Status: Needs review » Needs work

Thanks!

We should inherit from parent constructor here instead, and so no need for BlazySettingsForm::setConfigFactory():

+  public function __construct(ConfigFactoryInterface $config_factory, LibraryDiscovery $library_discovery) {
+    $this->libraryDiscovery = $library_discovery;
+
+    $this->setConfigFactory($config_factory);
+  }
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I think it's overwritten, another solution would be:
parent :: __ construct ($ config_factory);

Is that what you propose?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-5-D8.patch1.92 KB

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
gausarts’s picture

gausarts commented
Status: Needs review » Needs work

Need minor adjustment here:
https://www.drupal.org/pift-ci-job/1174101

Thank you!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-8-D8.patch19.21 KB

Follow the new patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-11-D8.patch2.56 KB

The last submitted patch, 2: blazy-Drupal_dependency_injection_on_BlazySettingsForm-3026114-2-D8.patch, failed testing. View results

  • gausarts committed 815cfe2 on 8.x-2.x authored by thalles 
    Issue #3026114 by thalles, gausarts: Drupal dependency injection on...
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

Committed. Thank you for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.