Moderation state missing on locked entities

I think this is a regression, because AFAICT #2901090: Disable content moderation buttons also fixed this about 1.5 year ago. Probably Content Moderation's implementation in core changed in the mean time.

Ideally, we'd add an explicit functional test for this to prevent this from regressing again.

Tested on the latest 8.x-2.x

And I'm actually not seeing the moderation state on the locked node.

I still can't replicate the original issue but not sure hiding the moderation state is correct either.

With this MR the moderation state is present but still correctly disabled.

rebased

Let's get some test coverage here so we can be sure this works on both Drupal 9 (which we still test on) and Drupal 10. If it only works on Drupal 10 it might be time to cut a new major.

Made the recommendation in slack but maybe we do a final release for 8.x-2.x and start a 3.0.x branch. And then we can drop D9 and merge in the change for D11 ticket.

Then can add test coverage for 3.0.x

Patch works for me (version 3.0.0-alpha4).
Thanks!

Got the same problem (of missing moderation state). The MR (or patch #9) fixes it. The content moderation controls are disabled if another user has locked the content, so I'm not sure why they were removed before.

I've created an MR based on #9 - going to add test coverage.

This issue appears to be about two things. The issue summary is a bug report that @smustgrave cannot reproduce. The rest of the issue is a discussion about whether the moderation buttons should appear on not. Note that the module is doing

        // Do not allow deletion, publishing, or unpublishing if locked.
        foreach (['delete', 'publish', 'unpublish'] as $key) {
          if (isset($form['actions'][$key])) {
            unset($form['actions'][$key]);
          }
        }

just above this code. I think we should widen the scope to include discussion of all the buttons like this. And how #disabled on the tope level of a form works and if different browsers have different interpretations of this.

So I think the problem here and why the unset is happening is because of code in FormBuilder

      // Make child elements inherit their parent's #disabled and #allow_focus
      // values unless they specify their own.
      foreach (['#disabled', '#allow_focus'] as $property) {
        if (isset($element[$property]) && !isset($element[$key][$property])) {
          $element[$key][$property] = $element[$property];
        }
      }

I think we need an after build to come it and ensure everything is truly disabled or otherwise this is fragile and probably we we were removing the elements.

This is only fixed on 3.x - won;t fix on 2.x because once 3.0.0 we're going to unsupport 2.x