Is there a way to have the banner at the bottom?

CommentFileSizeAuthor
#7 simple_cookie_compliance-n3025980-7.patch1.96 KBdamienmckenna
#6 banner-at-the-bottom-3025980-6.patch764 bytesguardiola86
#5 banner-at-the-bottom-3025980-5.patch391 bytesneslee canil pinto
#2 banner-at-the-bottom-3025980-2.patch976 bytesneslee canil pinto

Comments

cbe243 created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new banner-at-the-bottom-3025980-2.patch976 bytes

Banner At the Bottom

cbe243’s picture

cbe243 commented

Thank you!
Only problem, I couldn't find (or Terminal) the 

 /**
  * Implements hook_page_top().
  */
-function simple_cookie_compliance_page_top(array &$page_top) {
+function simple_cookie_compliance_page_bottom(array &$page_top) {
   $config = \Drupal::config('simple_cookie_compliance.settings');
   $use_no_script = $config->get('no_script', TRUE);
   $message = $config->get('message.value');

But instead, line 73, I replace $page['page_top']['simple_cookie_compliance'] = array( by $page['page_bottom']['simple_cookie_compliance'] = array( and it works.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented

Ok cbe243
Can you commit these changes or i have to apply another patch with updates

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
StatusFileSize
new banner-at-the-bottom-3025980-5.patch391 bytes

Updated the changes

guardiola86’s picture

guardiola86 commented
StatusFileSize
new banner-at-the-bottom-3025980-6.patch764 bytes

I've added some custom styling in case it's useful to anyone. I've made links yellow, added a media query to make it look good on mobile and adjusted paddings and margins.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new simple_cookie_compliance-n3025980-7.patch1.96 KB

This patch provides an option to control whether the message is shown at the top of the page (using the "page_top" region, which is how it works now) or at the bottom of the page (using the "page_bottom" region). It also adds an option on the settings page to control it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

BTW the rest of the changes are just CSS that can be added to the theme to customize the message as needed, so the patch in #7 removes the CSS changes of the previous patches.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

FWIW this is the CSS we're using in our theme to control the message's location:

.cookie-compliance {
  position: -webkit-sticky;
  position: sticky;
  bottom: 0;
  z-index: 100;
}