PHP will throw a warning when using the "Add terms" bulk modal form if the $parents var is null.

PHP Warning: count(): Parameter must be an array or an object that implements Countable in /app/web/modules/contrib/taxonomy_manager/src/TaxonomyManagerHelper.php on line 49

CommentFileSizeAuthor
#3 taxonomy_manager-dev-parameter-count-3025793-3.patch590 bytesaisforaaron
#2 taxonomy_manager-alpha2-parameter-count-3025793-2.patch590 bytesaisforaaron

Comments

aisforaaron created an issue. See original summary.

aisforaaron’s picture

aisforaaron commented
StatusFileSize
new taxonomy_manager-alpha2-parameter-count-3025793-2.patch590 bytes

I changed count() to !empty().

aisforaaron’s picture

aisforaaron commented
StatusFileSize
new taxonomy_manager-dev-parameter-count-3025793-3.patch590 bytes

The same patch against dev branch.

sergiu stici’s picture

sergiu stici commented
Status: Needs review » Reviewed & tested by the community

The patch #3 works for me, thanks.

ericdsd’s picture

ericdsd commented

patch #3 works for me too

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev
Assigned: aisforaaron » Unassigned

Already fixed for branch 2.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.