Hi,
We are getting the following error when running PHPCompatibility for 7.2
FILE:
/var/www/docroot/sites/all/contrib/entity_translation/includes/translation.handler.inc
713 | ERROR | Since PHP 7.0, functions inspecting arguments, like
| | func_get_args(), no longer report the original value
| | as passed to a parameter, but will instead provide the
| | current value. The parameter "$translation" was
| | changed on line 687.
Are we having any plans to fix this?
Thanks and regards,
Mayank Patel
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | php72-compactibility-3025770-9.patch | 821 bytes | sudheeshps |
| #5 | php72-compactibility-3025770.patch | 830 bytes | sudheeshps |
Comments
Comment #2
patelmayank7552 commentedComment #3
patelmayank7552 commentedComment #4
stefanos.petrakisThanks for this report, could you share some more info?
How does this error manifest itself?
Could you provide a case (would be important for reproducing errors)?
Why is this reported as critical?
Comment #5
sudheeshps commented@stefanos.petrakis this occurs when we run phpcompatibility tests on websites.
Most of the websites will perform this activity as php 7.1 deadline is declared.
This might be critical as all the codes scanned should pass the compatibility tests
I have added created a patch to fix the issue.
Comment #6
sudheeshps commentedComment #7
sudheeshps commentedComment #8
stefanos.petrakisThanks for the patch.
2 remarks, even though this is a simple patch:
* We need a comment explaining that
$argsis going to be used later on in a call tonotifyChildren(), since we are moving it away from that call* I would add the
$args = func_get_args();after the exception handling to optimize things a bit.Comment #9
sudheeshps commented@stefanos.petrakis, Thanks for the feedback.
Both the comments are addressed, let me know if further changes are required.
Comment #10
stefanos.petrakisComment #11
stefanos.petrakisComment #13
stefanos.petrakisCommitted, thanks for the help!
Comment #14
patelmayank7552 commentedComment #15
sudheeshps commented@ stefanos.petrakis Great, Any idea when are we planning for next release.
Comment #16
stefanos.petrakis@ sudheeshps : As there are no critical fixes in the current dev branch, the next release is not coming up in the near future (4-8 weeks roughly). Usually there is a rough number of ~10 (non-critical) fixes that triggers a new release and so far there are three commited fixes including this one.
Comment #17
joseph.olstad@stefanos.petrakis , I think this fix justifies a new tagged release . 7.x-1.1
Please and thank you! :)
Comment #19
joseph.olstadHi Stefanos, we should probably prioritize a release for 7.x-1.1 simply due to this commit.
php 7.1.x is now the lowest recommended version for Drupal 7 that is supported by 'Zend'.
although other vendors like RedHat back port security fixes to older php versions, no guarantee that other vendors will.
Comment #20
stefanos.petrakis