Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jan 2019 at 14:02 UTC
Updated:
19 May 2019 at 09:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
avpadernoThank you for applying! Remember to change status when the project is ready to be reviewed.
Comment #3
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.
Comment #4
abh.ai commentedSorry about that. Was busy. I'm changing the status to needs review. 8.x-1.4 is working fine.
Comment #5
abh.ai commentedComment #6
manish34jain commentedHello Abhaisasidharan,
I installed this on https://simplytest.me/. And i am getting website encountered an unexpected error message.
Please check the attached screenshot of error log.
Thanks
Comment #7
abh.ai commentedComment #8
avpadernoComment #9
saesa commentedComment #10
valentine94Hello, checked your module's code. Have the following advice to make it better:
In SCEditorController::scEditorPage you have to prevent using $_GET or $_POST superglobal variables it potentially dangerous and can cause the security issues, use Drupal's built-in request service instead, which can be called using DI as
$container->get('request_stack')->getCurrentRequest()or as static method\Drupal::request().Also, I don't see a LICENSE file within your module.
Regards, Valentine.
Comment #11
abh.ai commentedThanks Valentine94. I am updating now.
Comment #12
saesa commentedAdded PAReview checklist to summary
Comment #13
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.