Update gulp tooklit

> We need to push a new version for gulp-sass-inject too (https://github.com/pivica/gulp-sass-inject/issues/1)

Done.

I think we should also update yarn.lock files because it make sense we tell the child themes about exact dependencies we are using. But i figure it out just now that generator is not coping yarn.lock from a parent theme.

Not sure how yarn.lock will work with update hooks - i guess we need to update versions there also, lets first fix generator and then figure this.

> lets first fix generator and then figure this.

Fixed with https://www.drupal.org/commitlog/commit/90986/dbc0df6622df54dbc4b429695d....

> Also here the compiled CSS, seems like it was missing other compilations, as there the following things in:

Yeah, let's avoid this because we compile CSS only on point releases to avoid big patches and constant changing in base theme CSS which anyway we don't use in child themes.

Reviewing other stuff in patch #8 - i hope it has all changes and #9 is just compilation.

+++ b/themes/bs_bootstrap/bs_bootstrap.bs_base.install
@@ -0,0 +1,48 @@
+      '"stylelint-scss": "\^2.2.0"' => '"stylelint-scss": "^3.5.2"',

The package.json have here now

"stylelint-scss": "^3.5.4"

and here we are stating ^3.5.2, any special reason or maybe c&p error?

> I like to see the changed CSS, for review, but yes -it does not need to be commited. So removed too.

I am testing this locally against Primer so yeah for sure we will test it :)

Getting next error while doing drush bs-tu

Rebuilding CSS files                                                                                                             [ok]
/usr/lib/node_modules/gulp/bin/gulp.js:129
    gulpInst.start.apply(gulpInst, toRun);
                   ^

TypeError: Cannot read property 'apply' of undefined
    at /usr/lib/node_modules/gulp/bin/gulp.js:129:20
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickCallback (internal/process/next_tick.js:181:9)
    at Function.Module.runMain (module.js:696:11)
    at startup (bootstrap_node.js:204:16)
    at bootstrap_node.js:625:3

Investigating still.

Hmmm

3024835-update_gulp_toolkit-9.patch 326.9 KB
3024835-update_gulp_toolkit-12.patch 591.86 KB

that is like a lot of size diff?

I figure my global version of gulp was 3.x and just running

gulp sass

Was actually triggering global gulp and not local project gulp. Figure that if you run

yarn gulp sass

This will actually run a local version of gulp and i will not have gulpInst.start.apply(gulpInst, toRun); error any more.

However, then i've got next error

➜  primer_demo_theme git:(master) ✗ gulp -v
[08:03:59] CLI version 2.0.1
[08:03:59] Local version 4.0.0
➜  primer_demo_theme git:(master) ✗ gulp sass
[08:06:55] Using gulpfile ~/web/profiles/primer/themes/primer_demo_theme/gulpfile.js
[08:06:55] Starting 'sass'...
[08:06:55] 'sass' errored after 157 ms
[08:06:55] TypeError: plugins.stripCssComments is not a function
    at ~/web/themes/contrib/bs_base/gulp-tasks.js:67:21
    at taskWrapper (~/web/profiles/primer/themes/primer_demo_theme/node_modules/undertaker/lib/set-task.js:13:15)
    at bound (domain.js:395:14)
    at runBound (domain.js:408:12)
    at asyncRunner (~/web/profiles/primer/themes/primer_demo_theme/node_modules/async-done/index.js:55:18)
    at process._tickCallback (internal/process/next_tick.js:61:11)

Tried updating node 8.5.x, updated now to 10.15.3.

> Have you tried npm i -g gulp-cli to fix your issue, https://github.com/gulpjs/gulp-cli/issues/84 ?

Did this also.

Error for stripCssComments is still happening. Maybe this is related to our custom gulp code, but @ytsurk i am confused now how you can compile stuff without error and i can't? Maybe something else is different in our environment.

Finally, i did yarn list to provide here used packages and then i noticed that i have strip-css-comments package instead of gulp-strip-css-comments, so in updated theme, i am missing gulp wrapper so the error makes total sense then:

+++ b/themes/bs_bootstrap/bs_bootstrap.bs_base.install
@@ -0,0 +1,48 @@
+      '"gulp-strip-css-comments": "\^1.2.0"' => '"strip-css-comments": "^2.0.0"',

The package name is wrong, we should use gulp-strip-css-comments in updated version also.

Locally build work now, will check now rebuilt CSS to check that everything is fine in custom themes.

@ytsurk, @sasanikolic what do you think we update doc and scripts with yarn gulp sass instead of current gulp sass?

> It makes total sense to me using yarn to run gulp et al. But this should be covered in another issue too.

Agree, here is a follow-up issue #3041726: Use yarn to run gulp and document environment better.

> Suddenly I got this warning (needs debugging ..) when running yarn install width node.js 10:

Seems to me it's just a warning from node related to some library we are using. We could identify a library and update when this is fixed... Yeah, could be a follow-up i guess.

I've tested the latest patch version, tested changes in custom themes, all looks good now. Great stuff guys, thx :)

Committed.

Added node, yarn and gulp-cli information into https://www.drupal.org/docs/8/themes/bs-base/installation.

> This package (css-mqpacker) is no longer supported. We should replace or remove it in another issue.

Follow-up issue created #3042171: Decide what to do with css-mqpacker npm package is not maintained any more