Hi,

There is a bug when we use the redirect module with the current version of aegir and nginx server. When the (important) option "Enforce clean and canonical urls" is enabled, you get an infinite loop on every page. This is documented and recently fixed by 2 commits on the provision module for BOA (Barracuda-Octopus-Aegir).

It would be great if the patch could be added to the provision module on Drupal.org for Aegir.

Waiting, for people with the same problem, I wrote this patch against the 8.x-1.3 version of redirect module :
https://raw.githubusercontent.com/Mit-suko/patchouli/master/redirect_wor...

Thanks

Comments

Mitsuko created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Consensus Enterprises, Colan Schwartz Consulting commented

It looks like fixes are required in both Redirect and Provision. Would you kindly provide the Provision patch here? Thanks!

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

I'm going to commit these fixes and other changes today, since some were omitted before.

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Note that no fixes are required in the Redirect module, it was just incorrect Nginx config for D8.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Consensus Enterprises, Colan Schwartz Consulting commented

Thanks for keeping upstream up-to-date! :)

  • 2eba011 committed on 7.x-3.x 
    Issue #3024748 - Nginx config for D8 conflicts with Rewrite module

You...
memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Fix committed in:

https://cgit.drupalcode.org/provision/commit/?id=2eba011
https://cgit.drupalcode.org/provision/commit/?id=2e765c6

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented
Status: Active » Fixed
memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

I still need to sync the subdirs config, though..

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Done in https://cgit.drupalcode.org/provision/commit/?id=0421a14

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.