Problem/Motivation

Calls to check_markup in eu_cookie_compliance_page_attachments since they set the third argument to FALSE however per the API the third argument must be a string.
https://api.drupal.org/api/drupal/core%21modules%21filter%21filter.modul...

Proposed resolution

Remove the third argument since it defaults to an "empty" langcode.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#2 correct_check_markup_calls-3024494-2.patch2.5 KBerik frèrejean

Comments

Erik Frèrejean created an issue. See original summary.

erik frèrejean’s picture

erik frèrejean
Primary language Dutch
Location 🏴‍☠️
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new correct_check_markup_calls-3024494-2.patch2.5 KB

Status: Needs review » Needs work

The last submitted patch, 2: correct_check_markup_calls-3024494-2.patch, failed testing. View results

erik frèrejean’s picture

erik frèrejean
Primary language Dutch
Location 🏴‍☠️
commented
Status: Needs work » Needs review

Setting back to needs review. Test fail because there are no tests...

svenryen’s picture

svenryen commented
Status: Needs review » Reviewed & tested by the community

svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

Committed to -dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ciss’s picture

ciss commented

The same problem exists in the 7.x-1.x branch: https://git.drupalcode.org/project/eu-cookie-compliance/blob/b3e50b4f/eu...