Closed (fixed)
Project:
IMCE
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Jan 2019 at 18:40 UTC
Updated:
1 Jul 2019 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
medinasod commentedComment #3
steveash commentedCan verify this is a huge issue.
Comment #4
bernardopaulino commented+1
Comment #5
bitcookie commentedThis might be a core issue. The same behavior takes place using the image dialog without IMCE/uploads, just providing a path to an image. Switching back/fourth to source within CKEditor without saving also causes the bug.
This is related to the injected image tag's "data-entity-type" and "data-entity-uuid" attributes being empty. The plugin doesn't bind to these elements.
Example, an image that works, uploaded using core modules.
Example, an image provided by IMCE as a path, does not work.
Attached is an attempted core patch for this. It just ensures these properties are filled in (not empty).
It may be better to patch this wherever the image manipulation plugin binds. This way the plugin is tolerant of empty type/uuid attributes, which seems like a proper expression of the data. This approach provides values to trick the system into processing the image, which might cause other issues.
Comment #6
thallesA similar problem and with a closer solution in: #2850277: IMCE image caption support
Comment #7
thallesComment #8
medinasod commentedThis is not a duplicate issue.
Comment #9
thallesThanks!
Comment #10
thalles@medinasod, I believe that the issue solved this problem correctly without the use of a false uuid
Comment #11
medinasod commented@thalles I'll try out the patch. Thank you.
Comment #12
thalles@medinasod, there a problem security on the patch of the issue #2850277: IMCE image caption support
Comment #13
medinasod commented@thalles, what about the patch listed above (comment #5)? Has that been tested? Thank you.
Comment #14
thalles@see, it does not generate uuid, only add 0
Comment #15
thalles@medinasod, can you test the last patch in the #2850277: IMCE image caption support?
Comment #16
thallesFixed on #2850277: IMCE image caption support!
Comment #17
medinasod commented@thalles, I installed the dev version of IMCE, which has the fix from the issue you referenced, but it didn't fix the issue I'm reporting in this issue. The alternative text field is still empty when I open the dialog popup window when editing an embedded image. Thanks.
Comment #18
medinasod commentedComment #19
thallesDid you uninstall and reinstall IMCE?
Comment #20
medinasod commentedYes, I also updated the database, cleared cache, and double checked that the patch code is located in the module. Thanks.
Comment #21
medinasod commentedJust to be clear, I didn't use the patch that's linked to in comment #5, which is a patch for the core ckeditor module.
Comment #22
thalles@medinasod, would are this?
Comment #23
medinasod commented@thalles thank you for your help. Upon further testing, I noticed that the patch does work, but the alt text needs to be added the first time for existing images, then published. For example, when editing an existing page with an embedded image, the alternative text field in the popup is still empty. But after adding the text and publishing the page, the alternative text will appear in the popup subsequently. So in short, it seems the fix doesn't work retroactively for existing embedded images (which probably warrants a different issue). Thank you!
Comment #24
thallesThanks!