Closed (fixed)
Project:
Drupal core
Version:
8.7.x-dev
Component:
phpunit
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
7 Jan 2019 at 12:41 UTC
Updated:
22 Jan 2019 at 13:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
polComment #3
polComment #4
polComment #6
alexpottWhy isn't
EnvironmentTest::providerTestCheckMemoryLimit()failing on the DrupalCI when PHP 7.3 runs against HEAD?Comment #7
alexpottLol I know why. This test is very bogus. On DrupalCI the CLI limit is likely the same as my local - it's
-1to$twice_avail_memorygets set to-2MBwhich is nonsense. I think we should replace$twice_avail_memorywith3000000YBcause that is absurd.Comment #8
polHere's the updated patch.
Comment #9
fabianx commentedLooks good :)
Comment #10
alexpottCommitted and pushed e57c4a13e6 to 8.7.x and 7041c1c520 to 8.6.x. Thanks!
Let's change this to
// Test an unlimited memory limit.This shouldn't be here...
Fixed this all on commit.
Comment #13
polLooks like I wasn't really awake in the train this morning, thanks for fixing it @alex !!