[PHP 7.3] Fix BootstrapMiscTestCase::testCheckMemoryLimit() notice

Filtering the memory limit doesn't work as it could be specified in bytes, GB, etc.

Instead, we need to either parse the memory limit using parse_size(), or manually find the size, multiply, and recombine with any unit.

Oops that wasn't quite right, because MB was being tacked on to the byte size, which meant that the memory limit was multiplied by 1024 * 1024 * 2 instead of 2 :)

Unless I miss something the same problem exists in Drupal 8 in this file:

core/tests/Drupal/Tests/Component/Utility/EnvironmentTest.php

It needs to be fixed there first, before we can commit it to Drupal 7.

+++ b/modules/simpletest/tests/bootstrap.test
@@ -735,7 +735,7 @@ class BootstrapMiscTestCase extends DrupalUnitTestCase {
-    $twice_avail_memory = ($memory_limit * 2) . 'MB';
+    $twice_avail_memory = parse_size($memory_limit) * 2;

As commented on the D8 issue. On DrupalCi this value is -1 in CLI. So this test is not testing what we think it is. I would replace $twice_avail_memory with something absurd like 3000000YB

Hahaha I am trying to imagine what is 3,000,000 YB of RAM and have been unable to. That is way beyond the largest supercomputers or the 64-bit architecture limit. If every human being on the planet had like 100 billion smartphones each, then that would get you in the ballpark.

+++ b/modules/simpletest/tests/bootstrap.test
@@ -729,16 +729,12 @@ class BootstrapMiscTestCase extends DrupalUnitTestCase {
+    // Exceed a custom (unlimited) memory limit.

Let's sync this with the D8 changes made before committing.

Back to RTBC