Problem/Motivation

Show same empty feed table.

CommentFileSizeAuthor
#6 feeds-Enable_show_empty_feeds_table-3023743-6-D8.patch902 bytesthalles
#4 no-content.png17.8 KBmegachriz
#3 Screen Shot 2019-01-04 at 10.40.36 AM.png36.4 KBakash.addweb
#3 Screen Shot 2019-01-04 at 10.40.26 AM.png29.87 KBakash.addweb
#2 feeds-Enable_show_empty_feeds_table-3023743-2-D8.patch454 bytesthalles
feeds-empty-table.png76.7 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-Enable_show_empty_feeds_table-3023743-2-D8.patch454 bytes

Follow the patch!

akash.addweb’s picture

akash.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-01-04 at 10.40.26 AM.png29.87 KB
new Screen Shot 2019-01-04 at 10.40.36 AM.png36.4 KB

@thalles, Your patch is working fine for me, I checked it using simplytest.me & follow the below steps:
1). Add feed type from Config setting
2). Now navigate to Content
3). Shows feed tab
4). click on the feed tab.
Please review the attached screenshots.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new no-content.png17.8 KB

This is a nice idea, though I like to see a message in the table when there are no feeds.

This is the message that is shown by the node module when there is no content:

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Follow a new patch, now with the message.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new feeds-Enable_show_empty_feeds_table-3023743-6-D8.patch902 bytes

Follow now!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review

  • MegaChriz committed 217560f on 8.x-3.x authored by thalles 
    Issue #3023743 by thalles, Ronak.addweb, MegaChriz: Fixed show empty...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks for the patch! I changed the message to "There are no feeds yet." and committed that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.