Problem/Motivation

PHPStorm finds multiple definitions for drupal_set_message:
- drupal_set_message in ./core/include/bootstrap.inc
- drupal_set_message in ./modules/blazy/tests/src/Kernel/Form/BlazySettingsFormTest.php

As a result, the function is not marked as deprecated in PHPStorm.

Proposed resolution

Do not try to (re-)declare the drupal_set_message function in BlazySettingsFormTest.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

drupal_set_message is flagged as deprecated in PHPStorm

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 blazy-remove_drupal_set_message-3023431-2.patch1.94 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new blazy-remove_drupal_set_message-3023431-2.patch1.94 KB

Attached patch removes the duplicate drupal_set_message function in BlazySettingsFormTest.

gausarts’s picture

gausarts commented

Thanks for the catch!
Obviously, the tests and most codes were written a year ago, or so (26 May 2017). Things have changed a lot since then while I was away from Drupal for a year. If you find more deprecated functions to remove, feel free to create relevant issues mentioning a link to the relevant docs would also be helpful for the project documentation sake. So we all can learn directly from the horses' mouth.

  • gausarts committed d2ededc on 8.x-2.x authored by idebr 
    Issue #3023431 by idebr: drupal_set_message function declaration in...
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

Committed. Thank you for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.