All dependencies must be prefixed by project name, So please apply new {project}:{module}

CommentFileSizeAuthor
#2 3023399-2.patch264 bytesveerabhadra

Comments

veerabhadra created an issue. See original summary.

veerabhadra’s picture

veerabhadra commented
Status: Active » Needs review
StatusFileSize
new 3023399-2.patch264 bytes

This patch applied successfully, fixed the issue.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented

Looks good. However I would like a source for this. I have checked how other modules do this, and some uses the syntax of 

test_dependencies:
  - imce:imce
anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs review » Postponed (maintainer needs more info)
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed (maintainer needs more info) » Needs work

Yes, this is definitely wrong, drupal: is only for drupal core modules.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented

@Berdir: Any suggestions?

Is imce:imce the correct way?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yes, it is project:module, so imce:imce is correct. apart from core, it's almost always that, except if the project and module name differ or if you depend on a submodule of another project.

  • anon committed 62489e6 on 8.x-5.x 
    Issue #3023399 by veerabhadra, anon, Berdir: Dependencies must be...
anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.