Overriding PaymentInformation pane kill the payment process

I have trouble seeing what's actually going wrong. Could you try describing again?

Also, can you share your hook?

You must not change $panes['payment_information']['id'], the whole point of the alter hook is to replace the class without changing the ID.

It's fired by CheckoutPaneManager, but it's essentially core plugin code. We've had no issues with the hook so far.

Make sure that DepositPaymentInformation doesn't have an annotation of its own.
If it does, you might have have accidentally configured your checkout flow to use that pane instead of the original Payment information one.

Your screenshot confirms that your checkout flow is misconfigured.

"Payment information" is supposed to be enabled. That is the entry that you're pointing to your class via the alter hook.
"Deposit payment information" should not be enabled (and is better off not shown altogether).

In comment #11, the path to your class shouldn't use forward slashes... i.e. should be $panes['payment_information']['class'] = 'Path\To\YourNewClass';

Also having same problem for 1+ day.

So, does it mean that it is not possible to create custom PaymentInfo (and may be PaymentProcess?) plugin in a cool way where you pick required Panes via Commerce UI? Only must hardly replace class of core 'payment_information' in hook? Even with custom CheckoutFlow not possible?

UPDATE: found solution, see below ( https://www.drupal.org/project/commerce/issues/3023373#comment-14149243 )

@Aporie , you can use your custom PaymentInformation in way you planned (without hook):

/**
 * @CommerceCheckoutPane(
 *   id = "payment_information_aporie",
 *   label = @Translation("Payment information Aporie"),
 *   default_step = "order_information",
 *   wrapper_element = "fieldset",
 * )
 */
class PaymentInformationAporie extends PaymentInformation {
// ... do your magic here
}

but must create custom PaymentProcess also (and enable it in GUI)

/**
 * Provides the payment process pane.
 *
 * @CommerceCheckoutPane(
 *   id = "payment_process_aporie",
 *   label = @Translation("Payment process Aporie"),
 *   default_step = "payment",
 *   wrapper_element = "container",
 * )
 */
class PaymentProcessAporie extends PaymentProcess {
...
  // new function
  public function getPaymentInformationPane() {
    $panes = $this->checkoutFlow->getPanes();
    $name = 'payment_information';
    $namelen = strlen($name);
    $res = [];
    foreach($panes as $k => $p) {
      if( (substr($p->getId(), 0, $namelen) == $name) && $p->isVisible() && $p->getStepId() !== '_disabled') {
        $res[$k] = $p;
      }
    }
    if(count($res) > 1)
      throw new \RuntimeException("getPaymentInformationPane(): too much payment_information enabled");
    if(empty($res))
      throw new \RuntimeException("getPaymentInformationPane(): no payment_information enabled");
    
    return reset($res);
  }
  
  //overriden function
  public function isVisible() {
    if ($this->order->isPaid() || $this->order->getTotalPrice()->isZero()) {
      // No payment is needed if the order is free or has already been paid.
      return FALSE;
    }
    //$payment_info_pane = $this->checkoutFlow->getPane('payment_information');
    $payment_info_pane = $this->getPaymentInformationPane();
    if (!$payment_info_pane->isVisible() || $payment_info_pane->getStepId() == '_disabled') {
      // Hide the pane if the PaymentInformation pane has been disabled.
      return FALSE;
    }

    return TRUE;
  }

  //overriden function
  protected function getErrorStepId() {
    // Default to the step that contains the PaymentInformation pane.
    $payment_info_pane = $this->getPaymentInformationPane();
    $step_id = $payment_info_pane->getStepId();
    //$step_id = $this->checkoutFlow->getPane('payment_information')->getStepId();
    if ($step_id == '_disabled') {
      // Can't redirect to the _disabled step. This could mean that isVisible()
      // was overridden to allow PaymentProcess to be used without a
      // payment_information pane, but this method was not modified.
      throw new \RuntimeException('Cannot get the step ID for the payment_information pane. The pane is disabled.');
    }

    return $step_id;
  }
...
}

tested this right now, is working