Bulk Email module provides site administrators an interface to send mass email in easy and quick way.
In order to use the modules like "Views bulk operation" or "views send" module, email addresses should be entities in drupal system but not the such case with this module.
Use case - Lets suppose, you have long list of emails in text file and you want to send email to all email addresses. In that case this module will be helpful.

Project link

https://www.drupal.org/project/bulkemail

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/bulkemail.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-bulkemail.git

CommentFileSizeAuthor
#6 bulkemail-3023357-6.patch70 bytesbaliram.patil

Comments

RajeevChoudhary created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

rajeevchoudhary’s picture

rajeevchoudhary commented

Hi Kiamlaluno,

I have updated the code as per your comments. Please review and let me know if more information required.

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented

@rajeevchoudhary. still there are few items lets in PAReview. can you take care of those as well

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

I am changing status as per previous comment.

baliram.patil’s picture

baliram.patil commented
Status: Needs work » Needs review
StatusFileSize
new bulkemail-3023357-6.patch70 bytes
rajeevgole’s picture

rajeevgole
He/Him
Primary language English
commented

Suggest manually reviewing the patch. Good job.

rajeevgole’s picture

rajeevgole
He/Him
Primary language English
commented
Status: Needs review » Needs work

When I am taking the clone I can only see README.txt file.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The task of reviewers is pointing out what should be changed in the project files, not providing patch to fix issues.
We want the users who apply to show they are are able to understand the review and make the changes as suggested. Applying a patch provided by other users doesn't show that.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I can confirm there is just a README.txt file in the repository (https://cgit.drupalcode.org/bulkemail/tree/?h=8.x-1.x).

Also, the 8.x-1.0 branch should be removed, as the branch name is not correct. (It would be a valid tag name, though.)

rajeevchoudhary’s picture

rajeevchoudhary commented

Hi Guys,

I have added all the missing file and removed the 8.x-1.0 branch.

Please let me know if more improvement required.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
Korhan Kale’s picture

Korhan Kale commented

Hello RajeevChoudhary,

I have some code styling errors on the new files you added. I recommend you following this guide to fix some of them.

Also, I see some other issues:

  • Drupal\Component\Utility\UrlHelper is declared in MailForm.php but not used
  • Use of drupal_set_message which is deprecated, recommend you to use \Drupal::messenger() instead
  • Some declared but unused variables (e.g: in the submitForm method)
  • Where are you using the 'access all views' permission declared in your .permissions.yml file?
tgrass’s picture

tgrass commented

Hi RajeevChoudhary,
thank you for creating this project. I just checked your project and the following seems to me a little bit confusing:

- Name is "bulkemail" (e.g. https://www.drupal.org/project/bulkemail)
- Title is "Bulk mail"
- Application is "[D8] Bulk Email"
- In code you use "bulk_mail" or "bulk-mail". (e.g. "/admin/send-bulk-mail" or "bulk_mail.form")

Can you unify the naming (either bulkmail, bulkemail, bulk email or bulk mail)

This has no impact on the modules functionality but would be good to have a clean naming.

Cheers,

Thomas

saesa’s picture

saesa commented
Status: Needs review » Needs work

You should check the pareview review and correct the failures (https://pareview.sh/pareview/https-git.drupal.org-project-bulkemail.git).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.