Apparently, the 'router' table hasn’t been defined in system_schema() for several years now. Instead, it is being created lazily by the router.dumper service.
We should therefore remove all calls to $this->installSchema('system', ['router']); from our tests.

CommentFileSizeAuthor
#2 3023255-2--do_not_attempt_to_install_system_router_schema_in_tests.patch3.62 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3023255-2--do_not_attempt_to_install_system_router_schema_in_tests.patch3.62 KB

Let’s see if this just works now.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Reviewed & tested by the community

I've reviewed the patch and manually verified the following:

  • The router schema is no longer installed in tests
  • No additional tests have started failing (the 3 failures on php 5.5 are also present in current HEAD)

I therefore conclude that this patch is RTBC

  • drunken monkey committed 6cbfffb on 8.x-1.x 
    Issue #3023255 by drunken monkey, legolasbo: Removed installation of...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks a lot for reviewing!
Commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.