NodeCreationTrait was moved from namespace Drupal\simpletest to Drupal\Tests\node\Traits.
We should update all references accordingly.

CommentFileSizeAuthor
#2 3023247-2--adapt_NodeCreationTrait.patch572 bytesdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3023247-2--adapt_NodeCreationTrait.patch572 bytes
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Reviewed & tested by the community

I've reviewed the patch with the following findings:

  • The simpletest variant is indeed deprecated and informs us that the trait used in the patch should be used instead.
  • Manual check confirms that all references to NodeCreationTrait have been updated properly
  • The test failure for this patch is unrelated since those specific tests are also failing on HEAD.

This patch is therefore RTBC as far as I'm concerned

  • drunken monkey committed 56a0ee4 on 8.x-1.x 
    Issue #3023247 by drunken monkey, legolasbo: Updated references to...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.