Converting from an inline template to a twig.html template would make this easier for theme developers to override.

If we do this, it might make sense to have a new minor version for it.

CommentFileSizeAuthor
#3 twig_svg-3023153-refactor-twig-template-3.patch2.07 KBaaron.ferris

Comments

malcomio created an issue. See original summary.

aaron.ferris’s picture

aaron.ferris commented
Assigned: Unassigned » aaron.ferris

Looking into this

aaron.ferris’s picture

aaron.ferris commented
Status: Active » Needs review
StatusFileSize
new twig_svg-3023153-refactor-twig-template-3.patch2.07 KB
nathankg’s picture

nathankg commented
Category: Task » Feature request
Status: Needs review » Reviewed & tested by the community

I've Taken a look at the patch, all looks good to me. RTBC.

  • aaron.ferris authored a4c5b032 on 8.x-1.x 
    Issue #3023153 by aaron.ferris, nathankg: Consider refactoring to use a...
aaron.ferris’s picture

aaron.ferris commented
Status: Reviewed & tested by the community » Fixed

Thanks! - Committed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.